[gcc r13-8092] i386: Wrong code with __builtin_parityl [PR112672]

[gcc r13-8092] i386: Wrong code with __builtin_parityl [PR112672]

[Uros Bizjak]

https://gcc.gnu.org/g:d035b57d51167af805ccc91ee0492c8b27e22184

commit r13-8092-gd035b57d51167af805ccc91ee0492c8b27e22184
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Thu Nov 23 16:17:57 2023 +0100

    i386: Wrong code with __builtin_parityl [PR112672]
    
    gen_parityhi2_cmp instruction clobbers its input operand, so use
    a temporary register in the call to gen_parityhi2_cmp.
    
            PR target/112672
    
    gcc/ChangeLog:
    
            * config/i386/i386.md (parityhi2):
            Use temporary register in the call to gen_parityhi2_cmp.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/i386/pr112672.c: New test.
    
    (cherry picked from commit b2d17bdd45b582b93e89c00b04763a45f97d7a34)

Diff:
---
 gcc/config/i386/i386.md                  |  4 +++-
 gcc/testsuite/gcc.target/i386/pr112672.c | 23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
index d6e25db9d01..09c7df7ea83 100644
--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -18389,8 +18389,10 @@
   "! TARGET_POPCNT"
 {
   rtx scratch = gen_reg_rtx (QImode);
+  rtx tmp = gen_reg_rtx (HImode);
 
-  emit_insn (gen_parityhi2_cmp (operands[1]));
+  emit_move_insn (tmp, operands[1]);
+  emit_insn (gen_parityhi2_cmp (tmp));
 
   ix86_expand_setcc (scratch, ORDERED,
 		     gen_rtx_REG (CCmode, FLAGS_REG), const0_rtx);
diff --git a/gcc/testsuite/gcc.target/i386/pr112672.c b/gcc/testsuite/gcc.target/i386/pr112672.c
new file mode 100644
index 00000000000..583e9fdfb8b
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr112672.c
@@ -0,0 +1,23 @@
+/* PR target/112672 */
+/* { dg-do run } */
+/* { dg-options "-O2" } */
+
+typedef unsigned short u16;
+
+u16 g = 254;
+
+static inline u16
+foo (u16 u)
+{
+  u *= g;
+  return u + __builtin_parityl (u);
+}
+
+int
+main (void)
+{
+  u16 x = foo (4);
+  if (x != 4 * 254 + 1)
+    __builtin_abort ();
+  return 0;
+}