public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-6180] i386: Fix -fcf-protection -Os ICE due to movabsq peephole2 [PR112845] Date: Tue, 5 Dec 2023 12:18:37 +0000 (GMT) [thread overview] Message-ID: <20231205121837.4E9F33858C52@sourceware.org> (raw) https://gcc.gnu.org/g:e0786ca9a18c50ad08c40936b228e325193664b8 commit r14-6180-ge0786ca9a18c50ad08c40936b228e325193664b8 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Dec 5 13:17:57 2023 +0100 i386: Fix -fcf-protection -Os ICE due to movabsq peephole2 [PR112845] The following testcase ICEs in the movabsq $(i32 << shift), r64 peephole2 I've added a while back to use smaller code than movabsq if possible. If i32 is 0xfa1e0ff3 and shift is not divisible by 8, then it creates an invalid insn (as 0xfa1e0ff3 CONST_INT is not allowed as x86_64_immediate_operand nor x86_64_zext_immediate_operand), the peephole2 even triggers on it again and again (this time with shift 0) until it gives up. The following patch fixes that. As ix86_endbr_immediate_operand needs a CONST_INT and it is hopefully rare, I chose to use FAIL rather than handling it in the condition (where I'd probably need to call ctz_hwi again etc.). 2023-12-05 Jakub Jelinek <jakub@redhat.com> PR target/112845 * config/i386/i386.md (movabsq $(i32 << shift), r64 peephole2): FAIL if the new immediate is ix86_endbr_immediate_operand. Diff: --- gcc/config/i386/i386.md | 5 ++++- gcc/testsuite/gcc.dg/pr112845.c | 9 +++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 7641b479670..df7f9172381 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -2699,7 +2699,10 @@ (clobber (reg:CC FLAGS_REG))])] { int shift = ctz_hwi (UINTVAL (operands[1])); - operands[1] = gen_int_mode (UINTVAL (operands[1]) >> shift, DImode); + rtx op1 = gen_int_mode (UINTVAL (operands[1]) >> shift, DImode); + if (ix86_endbr_immediate_operand (op1, VOIDmode)) + FAIL; + operands[1] = op1; operands[2] = gen_int_mode (shift, QImode); }) diff --git a/gcc/testsuite/gcc.dg/pr112845.c b/gcc/testsuite/gcc.dg/pr112845.c new file mode 100644 index 00000000000..ece6f451e75 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr112845.c @@ -0,0 +1,9 @@ +/* PR target/112845 */ +/* { dg-do compile { target cet } } */ +/* { dg-options "-Os -fcf-protection" } */ + +unsigned long long +foo (void) +{ + return 0xfa1e0ff3ULL << 3; +}
reply other threads:[~2023-12-05 12:18 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231205121837.4E9F33858C52@sourceware.org \ --to=jakub@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).