public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-6208] driver: Fix bootstrap with --enable-default-pie Date: Wed, 6 Dec 2023 08:54:54 +0000 (GMT) [thread overview] Message-ID: <20231206085454.A0A6F3858D38@sourceware.org> (raw) https://gcc.gnu.org/g:895a70f012b8c1b8e80ecc584c1d7ded014bc2bc commit r14-6208-g895a70f012b8c1b8e80ecc584c1d7ded014bc2bc Author: Jakub Jelinek <jakub@redhat.com> Date: Wed Dec 6 09:54:03 2023 +0100 driver: Fix bootstrap with --enable-default-pie On IRC Iain mentioned bootstrap is broken for him presumably since r14-5791 -fhardened addition. I think it is only a problem with --enable-default-pie when the case OPT_pie: wants to fall through into case OPT_r: and warns. Before the patch validated = true; was set up if ENABLE_DEFAULT_PIE for OPT_pie, and for -fhardened as documented I think we want to set any_link_options_p = true; for it too: /* True if -r, -shared, -pie, or -no-pie were specified on the command line. */ static bool any_link_options_p; 2023-12-06 Jakub Jelinek <jakub@redhat.com> * gcc.cc (driver_handle_option): Add /* FALLTHROUGH */ comment between OPT_pie and OPT_r cases. Diff: --- gcc/gcc.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/gcc.cc b/gcc/gcc.cc index 9f21ad9453e..03ec6e1cb2f 100644 --- a/gcc/gcc.cc +++ b/gcc/gcc.cc @@ -4617,6 +4617,7 @@ driver_handle_option (struct gcc_options *opts, /* -pie is turned on by default. */ validated = true; #endif + /* FALLTHROUGH */ case OPT_r: case OPT_shared: case OPT_no_pie:
reply other threads:[~2023-12-06 8:54 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231206085454.A0A6F3858D38@sourceware.org \ --to=jakub@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).