public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-7622] gccrs: remove useless lookup to NodeId
@ 2024-01-16 17:46 Arthur Cohen
0 siblings, 0 replies; only message in thread
From: Arthur Cohen @ 2024-01-16 17:46 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:e07cb0b07d50ffa6b8533c4e0f65b6a4829d2823
commit r14-7622-ge07cb0b07d50ffa6b8533c4e0f65b6a4829d2823
Author: Philip Herron <herron.philip@googlemail.com>
Date: Tue May 30 12:10:40 2023 +0100
gccrs: remove useless lookup to NodeId
gcc/rust/ChangeLog:
* backend/rust-compile-expr.cc (CompileExpr::visit): remove unused
Signed-off-by: Philip Herron <herron.philip@googlemail.com>
Diff:
---
gcc/rust/backend/rust-compile-expr.cc | 33 +++------------------------------
1 file changed, 3 insertions(+), 30 deletions(-)
diff --git a/gcc/rust/backend/rust-compile-expr.cc b/gcc/rust/backend/rust-compile-expr.cc
index 93dd937da6f..5152c99362f 100644
--- a/gcc/rust/backend/rust-compile-expr.cc
+++ b/gcc/rust/backend/rust-compile-expr.cc
@@ -1698,23 +1698,6 @@ CompileExpr::visit (HIR::MethodCallExpr &expr)
// method receiver
tree self = CompileExpr::Compile (expr.get_receiver ().get (), ctx);
- // lookup the resolved name
- NodeId resolved_node_id = UNKNOWN_NODEID;
- if (!ctx->get_resolver ()->lookup_resolved_name (
- expr.get_mappings ().get_nodeid (), &resolved_node_id))
- {
- rust_error_at (expr.get_locus (), "failed to lookup resolved MethodCall");
- return;
- }
-
- // reverse lookup
- HirId ref;
- if (!ctx->get_mappings ()->lookup_node_to_hir (resolved_node_id, &ref))
- {
- rust_fatal_error (expr.get_locus (), "reverse lookup failure");
- return;
- }
-
// lookup the expected function type
TyTy::BaseType *lookup_fntype = nullptr;
bool ok = ctx->get_tyctx ()->lookup_type (
@@ -1871,20 +1854,10 @@ CompileExpr::resolve_operator_overload (
expr.get_mappings ().get_hirid (), &fntype);
rust_assert (is_op_overload);
- // lookup the resolved name
- NodeId resolved_node_id = UNKNOWN_NODEID;
- bool ok = ctx->get_resolver ()->lookup_resolved_name (
- expr.get_mappings ().get_nodeid (), &resolved_node_id);
- rust_assert (ok);
-
- // reverse lookup
- HirId ref;
- ok = ctx->get_mappings ()->lookup_node_to_hir (resolved_node_id, &ref);
- rust_assert (ok);
-
TyTy::BaseType *receiver = nullptr;
- ok = ctx->get_tyctx ()->lookup_receiver (expr.get_mappings ().get_hirid (),
- &receiver);
+ bool ok
+ = ctx->get_tyctx ()->lookup_receiver (expr.get_mappings ().get_hirid (),
+ &receiver);
rust_assert (ok);
bool is_generic_receiver = receiver->get_kind () == TyTy::TypeKind::PARAM;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-16 17:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-16 17:46 [gcc r14-7622] gccrs: remove useless lookup to NodeId Arthur Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).