From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7905) id 07DF438582A3; Tue, 16 Jan 2024 18:07:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07DF438582A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1705428466; bh=JCDo2P9X4ESdS0dm0YooH3hmXXmpV8UX6WTyk0nKX6M=; h=From:To:Subject:Date:From; b=HuVAMfDTtUdyn0AWWgTbDxzkcoO9DMvRgNPqPfWJD9DtpxExG5E1e9W2G13TnTT3E E53Er7/ED3RCe0F9VAsCvOpFg+R4SdMNM+hFi7luy+ZAg62G2y16aCm4xgaOXKT7YP 0Zc3YO8CNHRw8FiMMkzqd0RseO6Sj5JyckAXBBTU= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Arthur Cohen To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-7924] gccrs: [E0753] Use of inner doc comment in invalid context X-Act-Checkin: gcc X-Git-Author: Muhammad Mahad X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 4ad44eae61457754cb0249bb6df24cc33f684163 X-Git-Newrev: c0b25c9a3b25510d47cdf6b37afaf208c00a1c0d Message-Id: <20240116180746.07DF438582A3@sourceware.org> Date: Tue, 16 Jan 2024 18:07:45 +0000 (GMT) List-Id: https://gcc.gnu.org/g:c0b25c9a3b25510d47cdf6b37afaf208c00a1c0d commit r14-7924-gc0b25c9a3b25510d47cdf6b37afaf208c00a1c0d Author: Muhammad Mahad Date: Thu Aug 17 10:13:00 2023 +0500 gccrs: [E0753] Use of inner doc comment in invalid context gcc/rust/ChangeLog: * parse/rust-parse-impl.h (Parser::parse_outer_attribute): Added errorcode & updated error function. gcc/testsuite/ChangeLog: * rust/compile/bad_inner_doc.rs: Updated comment to pass testcase. Signed-off-by: Muhammad Mahad Diff: --- gcc/rust/parse/rust-parse-impl.h | 5 +++-- gcc/testsuite/rust/compile/bad_inner_doc.rs | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/gcc/rust/parse/rust-parse-impl.h b/gcc/rust/parse/rust-parse-impl.h index d8d82b36391..ca58d5e571a 100644 --- a/gcc/rust/parse/rust-parse-impl.h +++ b/gcc/rust/parse/rust-parse-impl.h @@ -1218,8 +1218,9 @@ Parser::parse_outer_attribute () if (lexer.peek_token ()->get_id () == INNER_DOC_COMMENT) { Error error ( - lexer.peek_token ()->get_locus (), - "inner doc (% or %) only allowed at start of item " + lexer.peek_token ()->get_locus (), ErrorCode::E0753, + "expected outer doc comment, inner doc (% or %) only " + "allowed at start of item " "and before any outer attribute or doc (%<#[%>, % or %)"); add_error (std::move (error)); lexer.skip_token (); diff --git a/gcc/testsuite/rust/compile/bad_inner_doc.rs b/gcc/testsuite/rust/compile/bad_inner_doc.rs index cfd166ce3ec..96f3b4b6ed2 100644 --- a/gcc/testsuite/rust/compile/bad_inner_doc.rs +++ b/gcc/testsuite/rust/compile/bad_inner_doc.rs @@ -2,13 +2,13 @@ pub fn main () { //! inner doc allowed let _x = 42; - // { dg-error "inner doc" "" { target *-*-* } .+1 } + // { dg-error "expected outer doc comment, inner doc" "" { target *-*-* } .+1 } //! inner doc disallowed mod module { /*! inner doc allowed */ /// outer doc allowed - // { dg-error "inner doc" "" { target *-*-* } .+1 } + // { dg-error "expected outer doc comment, inner doc" "" { target *-*-* } .+1 } /*! but inner doc not here */ mod x { } }