public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-7931] gccrs: Non-allowed default type paramters
@ 2024-01-16 18:08 Arthur Cohen
0 siblings, 0 replies; only message in thread
From: Arthur Cohen @ 2024-01-16 18:08 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:dd343c42d25d2ab2cc1549c5cf608d7d6b3f0589
commit r14-7931-gdd343c42d25d2ab2cc1549c5cf608d7d6b3f0589
Author: Muhammad Mahad <mahadtxt@gmail.com>
Date: Mon Aug 14 17:09:25 2023 +0500
gccrs: Non-allowed default type paramters
gcc/rust/ChangeLog:
* hir/rust-ast-lower-item.cc (ASTLoweringItem::visit):
Added more helpful error message.
gcc/testsuite/ChangeLog:
* rust/compile/generics10.rs: for dejagnu.
Signed-off-by: Muhammad Mahad <mahadtxt@gmail.com>
Diff:
---
gcc/rust/hir/rust-ast-lower-item.cc | 24 +++++++++++++++++-------
gcc/testsuite/rust/compile/generics10.rs | 2 +-
2 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/gcc/rust/hir/rust-ast-lower-item.cc b/gcc/rust/hir/rust-ast-lower-item.cc
index 6eaf75ffd0b..6d91c23e8d2 100644
--- a/gcc/rust/hir/rust-ast-lower-item.cc
+++ b/gcc/rust/hir/rust-ast-lower-item.cc
@@ -499,10 +499,15 @@ ASTLoweringItem::visit (AST::InherentImpl &impl_block)
if (t.has_type ())
{
- // see https://github.com/rust-lang/rust/issues/36887
- rust_error_at (
+ rich_location rich_locus (line_table, t.get_locus ());
+ rich_locus.add_fixit_replace (
t.get_locus (),
- "defaults for type parameters are not allowed here");
+ "for more information, see issue #36887 "
+ "<https://github.com/rust-lang/rust/issues/36887>");
+ rust_error_at (rich_locus,
+ "defaults for type parameters are only "
+ "allowed in %<struct%>, %<enum%>, %<type%>, "
+ "or %<trait%> definitions");
}
}
break;
@@ -645,10 +650,15 @@ ASTLoweringItem::visit (AST::TraitImpl &impl_block)
if (t.has_type ())
{
- // see https://github.com/rust-lang/rust/issues/36887
- rust_error_at (
- t.get_locus (),
- "defaults for type parameters are not allowed here");
+ rich_location rich_locus (line_table, t.get_locus ());
+ rich_locus.add_fixit_replace (
+ t.get_locus (), "for more information, see issue #36887 "
+ "<https://github.com/rust-lang/rust/"
+ "issues/36887>");
+ rust_error_at (rich_locus,
+ "defaults for type parameters are only "
+ "allowed in %<struct%>, %<enum%>, %<type%>, "
+ "or %<trait%> definitions");
}
}
break;
diff --git a/gcc/testsuite/rust/compile/generics10.rs b/gcc/testsuite/rust/compile/generics10.rs
index a734fa8a197..c66a08f7e16 100644
--- a/gcc/testsuite/rust/compile/generics10.rs
+++ b/gcc/testsuite/rust/compile/generics10.rs
@@ -1,6 +1,6 @@
struct Foo<A, B>(A, B);
-impl<X = i32> Foo<X, f32> { // { dg-error "defaults for type parameters are not allowed here" }
+impl<X = i32> Foo<X, f32> { // { dg-error "defaults for type parameters are only allowed in .struct., .enum., .type., or .trait. definitions" }
fn new(a: X, b: f32) -> Self {
Self(a, b)
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-01-16 18:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-16 18:08 [gcc r14-7931] gccrs: Non-allowed default type paramters Arthur Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).