public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Philipp Tomsich <ptomsich@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/vendors/vrull/heads/slp-improvements)] Fix: Do not rearrange splat vectors in try_rearrange_oprnd_info
Date: Wed, 17 Jan 2024 19:15:12 +0000 (GMT) [thread overview]
Message-ID: <20240117191512.190403858C62@sourceware.org> (raw)
https://gcc.gnu.org/g:e6131c9e42d5bae8586341c60ca8cb0a26b595ca
commit e6131c9e42d5bae8586341c60ca8cb0a26b595ca
Author: Manolis Tsamis <manolis.tsamis@vrull.eu>
Date: Wed Dec 6 14:34:50 2023 +0100
Fix: Do not rearrange splat vectors in try_rearrange_oprnd_info
Check that the vector elements taking part in a rearranged pattern
(e.g. ABAB) are actually different. Otherwise a splat vector (AAAA)
would be considered to fulfill any rearrangement pattern. We don't
want to merge splat vectors together in a mixed node as that can both
reduce performance and cause codegen issues.
Ref #342
Diff:
---
gcc/tree-vect-slp.cc | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc
index 8f2993b84f1..28defc56d29 100644
--- a/gcc/tree-vect-slp.cc
+++ b/gcc/tree-vect-slp.cc
@@ -1842,15 +1842,18 @@ try_rearrange_oprnd_info (vec<slp_oprnd_info> &oprnds_info, unsigned group_size)
int cur_pattern = 0;
/* Check for an ABAB... pattern. */
if ((oprnd_info->def_stmts[j] == oprnd_info->def_stmts[j + 2])
- && (oprnd_info->def_stmts[j + 1] == oprnd_info->def_stmts[j + 3]))
+ && (oprnd_info->def_stmts[j + 1] == oprnd_info->def_stmts[j + 3])
+ && (oprnd_info->def_stmts[j] != oprnd_info->def_stmts[j + 1]))
cur_pattern = 1;
/* Check for an AABB... pattern. */
else if ((oprnd_info->def_stmts[j] == oprnd_info->def_stmts[j + 1])
- && (oprnd_info->def_stmts[j + 2] == oprnd_info->def_stmts[j + 3]))
+ && (oprnd_info->def_stmts[j + 2] == oprnd_info->def_stmts[j + 3])
+ && (oprnd_info->def_stmts[j] != oprnd_info->def_stmts[j + 2]))
cur_pattern = 2;
/* Check for an ABBA... pattern. */
else if ((oprnd_info->def_stmts[j] == oprnd_info->def_stmts[j + 3])
- && (oprnd_info->def_stmts[j + 1] == oprnd_info->def_stmts[j + 2]))
+ && (oprnd_info->def_stmts[j + 1] == oprnd_info->def_stmts[j + 2])
+ && (oprnd_info->def_stmts[j] != oprnd_info->def_stmts[j + 1]))
cur_pattern = 3;
/* Unrecognised pattern. */
else
next reply other threads:[~2024-01-17 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 19:15 Philipp Tomsich [this message]
2024-01-23 20:58 Philipp Tomsich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240117191512.190403858C62@sourceware.org \
--to=ptomsich@gcc.gnu.org \
--cc=gcc-cvs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).