From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7856) id 63A853858C50; Tue, 23 Jan 2024 08:02:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63A853858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1705996969; bh=GrS/u2OcadjnKL7giv/U7MtIisyuiK48JxMgl2lZJbU=; h=From:To:Subject:Date:From; b=tdRr1dqvN5SjiGs0HsywXdP/tkbHxAD++9cStaFizfZnKusKWUzKwEM2VZqS/x3R8 IrugO2tJyMdgxiDvN0I8+RCcrvOvDcqUEXktGhdVrrRCqydJlhl+NBLB5dD+0tKrOq zkHvKIj49Nw2VmWf5PbtmZEYqzQ5/efCx+quzstY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Xi Ruoyao To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-8348] LoongArch: Disable explicit reloc for TLS LD/GD with -mexplicit-relocs=auto X-Act-Checkin: gcc X-Git-Author: Xi Ruoyao X-Git-Refname: refs/heads/master X-Git-Oldrev: 23ebb09ed2e88c1f292d4232c1fd2974cc5c79e6 X-Git-Newrev: f12317306ee714aed0ca7ed01cafa520296b4c4c Message-Id: <20240123080249.63A853858C50@sourceware.org> Date: Tue, 23 Jan 2024 08:02:49 +0000 (GMT) List-Id: https://gcc.gnu.org/g:f12317306ee714aed0ca7ed01cafa520296b4c4c commit r14-8348-gf12317306ee714aed0ca7ed01cafa520296b4c4c Author: Xi Ruoyao Date: Mon Jan 22 18:07:42 2024 +0800 LoongArch: Disable explicit reloc for TLS LD/GD with -mexplicit-relocs=auto Binutils 2.42 supports TLS LD/GD relaxation which requires the assembler macro. gcc/ChangeLog: * config/loongarch/loongarch.cc (loongarch_explicit_relocs_p): If la_opt_explicit_relocs is EXPLICIT_RELOCS_AUTO, return false for SYMBOL_TLS_LDM and SYMBOL_TLS_GD. (loongarch_call_tls_get_addr): Do not split symbols of SYMBOL_TLS_LDM or SYMBOL_TLS_GD if la_opt_explicit_relocs is EXPLICIT_RELOCS_AUTO. gcc/testsuite/ChangeLog: * gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c: Check for la.tls.ld and la.tls.gd. Diff: --- gcc/config/loongarch/loongarch.cc | 10 +++++----- .../gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/gcc/config/loongarch/loongarch.cc b/gcc/config/loongarch/loongarch.cc index 82467474288..072c68d97e3 100644 --- a/gcc/config/loongarch/loongarch.cc +++ b/gcc/config/loongarch/loongarch.cc @@ -1970,11 +1970,11 @@ loongarch_explicit_relocs_p (enum loongarch_symbol_type type) { case SYMBOL_TLS_IE: case SYMBOL_TLS_LE: - case SYMBOL_TLSGD: - case SYMBOL_TLSLDM: case SYMBOL_PCREL64: - /* The linker don't know how to relax TLS accesses or 64-bit - pc-relative accesses. */ + /* TLS IE cannot be relaxed. TLS LE relaxation is different from + the normal R_LARCH_RELAX-based relaxation and it **requires** + using the explicit %le_{lo12,hi20,add}_r relocs. The linker + does not relax 64-bit pc-relative accesses as at now. */ return true; case SYMBOL_GOT_DISP: /* The linker don't know how to relax GOT accesses in extreme @@ -2789,7 +2789,7 @@ loongarch_call_tls_get_addr (rtx sym, enum loongarch_symbol_type type, rtx v0) start_sequence (); - if (la_opt_explicit_relocs != EXPLICIT_RELOCS_NONE) + if (la_opt_explicit_relocs == EXPLICIT_RELOCS_ALWAYS) { /* Split tls symbol to high and low. */ rtx high = gen_rtx_HIGH (Pmode, copy_rtx (loc)); diff --git a/gcc/testsuite/gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c b/gcc/testsuite/gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c index 957ff98df62..ca55fcfc53e 100644 --- a/gcc/testsuite/gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c +++ b/gcc/testsuite/gcc.target/loongarch/explicit-relocs-auto-tls-ld-gd.c @@ -6,4 +6,5 @@ extern __thread int b __attribute__((visibility("default"))); int test() { return a + b; } -/* { dg-final { scan-assembler-not "la.tls" { target tls_native } } } */ +/* { dg-final { scan-assembler "la\\.tls\\.ld" { target tls_native } } } */ +/* { dg-final { scan-assembler "la\\.tls\\.gd" { target tls_native } } } */