From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 72A99385842A; Tue, 23 Jan 2024 10:15:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72A99385842A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1706004947; bh=kvLLxoFfvLGlTO5RrPMDbLC8kxDzBAQUNxzlKHgscck=; h=From:To:Subject:Date:From; b=hoHpH+T7Wr2VVoOfTss73f2acUUO4ToZfOAdxkBq6BSZrTZW+xTe+U7luGrvTqUiZ h+pnW59664NvfstMcKH6aXmCIf2dgBHAmaCAxPpIMrz1akYTanNm4cITvrZwwVFXHk ULzhM+wUcy6vovACrhHqqi88VKtRXK26eqkz7Ras= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-8351] debug/107058 - gracefully handle unexpected DIE contexts X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: affef534b0335592336c82918f15242576e2ab8f X-Git-Newrev: e2f3057fc911f9f55986b3de237b0155c0e09fe8 Message-Id: <20240123101547.72A99385842A@sourceware.org> Date: Tue, 23 Jan 2024 10:15:47 +0000 (GMT) List-Id: https://gcc.gnu.org/g:e2f3057fc911f9f55986b3de237b0155c0e09fe8 commit r14-8351-ge2f3057fc911f9f55986b3de237b0155c0e09fe8 Author: Richard Biener Date: Tue Jan 23 09:51:00 2024 +0100 debug/107058 - gracefully handle unexpected DIE contexts While the bug is persisting that LTO streaming picks up a CONST_DECL from an attribute argument on a VAR_DECL which with -fdebug-type-section refers to a DIE in a type unit we can handle this gracefully, at least with -fno-checking. Do so. The C++ frontend nevetheless should resolve the CONST_DECL attribute argument to a constant. PR debug/107058 * dwarf2out.cc (dwarf2out_die_ref_for_decl): Gracefully handle unexpected but bogus DIE contexts when not checking enabled. * c-c++-common/pr107058.c: New testcase. Diff: --- gcc/dwarf2out.cc | 15 +++++++++++---- gcc/testsuite/c-c++-common/pr107058.c | 7 +++++++ 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc index 0b8a3002292..2b723210f34 100644 --- a/gcc/dwarf2out.cc +++ b/gcc/dwarf2out.cc @@ -6061,10 +6061,17 @@ dwarf2out_die_ref_for_decl (tree decl, const char **sym, die = die->die_parent; /* For the containing CU DIE we compute a die_symbol in compute_comp_unit_symbol. */ - gcc_assert (die->die_tag == DW_TAG_compile_unit - && die->die_id.die_symbol != NULL); - *sym = die->die_id.die_symbol; - return true; + if (die->die_tag == DW_TAG_compile_unit) + { + gcc_assert (die->die_id.die_symbol != NULL); + *sym = die->die_id.die_symbol; + return true; + } + /* While we can gracefully handle running into say a type unit + we don't really want and consider this a bug. */ + if (flag_checking) + gcc_unreachable (); + return false; } /* Add a reference of kind ATTR_KIND to a DIE at SYMBOL + OFFSET to DIE. */ diff --git a/gcc/testsuite/c-c++-common/pr107058.c b/gcc/testsuite/c-c++-common/pr107058.c new file mode 100644 index 00000000000..5e625d6a6af --- /dev/null +++ b/gcc/testsuite/c-c++-common/pr107058.c @@ -0,0 +1,7 @@ +/* { dg-do compile } */ +/* { dg-require-effective-target lto } */ +/* { dg-options "-g -fdebug-types-section -flto -fno-checking" } */ + +/* We should handle the C++ FE issue gracefully with -fno-checking. */ + +#include "pr50459.c"