public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Philipp Tomsich <ptomsich@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/vendors/vrull/heads/slp-improvements)] Fix: Do not create mixed operation SLP nodes when rearranging Date: Tue, 23 Jan 2024 20:58:59 +0000 (GMT) [thread overview] Message-ID: <20240123205859.5590538582B7@sourceware.org> (raw) https://gcc.gnu.org/g:441e8bc477724c8be1b18132c9f39fe355daea79 commit 441e8bc477724c8be1b18132c9f39fe355daea79 Author: Manolis Tsamis <manolis.tsamis@vrull.eu> Date: Wed Dec 20 09:56:31 2023 +0100 Fix: Do not create mixed operation SLP nodes when rearranging Ref #342 Diff: --- gcc/tree-vect-slp.cc | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 732affece3b..04184cab1cf 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -1820,7 +1820,8 @@ vect_slp_build_two_operator_nodes (slp_tree perm, tree vectype, SLP_TREE_CHILDREN (perm).quick_push (child2); } -enum slp_oprnd_pattern { +enum slp_oprnd_pattern +{ SLP_OPRND_PATTERN_NONE, SLP_OPRND_PATTERN_ABAB, SLP_OPRND_PATTERN_AABB, @@ -1837,11 +1838,24 @@ try_rearrange_oprnd_info (vec<slp_oprnd_info> &oprnds_info, unsigned group_size) if (oprnds_info.length() != 2 || group_size % 4 != 0) return SLP_OPRND_PATTERN_NONE; + enum tree_code code = oprnds_info[0]->def_stmts[0] ? + gimple_assign_rhs_code (oprnds_info[0]->def_stmts[0]->stmt) + : ERROR_MARK; + FOR_EACH_VEC_ELT (oprnds_info, i, oprnd_info) for (unsigned int j = 0; j < group_size; j += 1) - if (!oprnd_info->def_stmts[j] - || STMT_VINFO_DATA_REF (oprnd_info->def_stmts[j])) - return SLP_OPRND_PATTERN_NONE; + { + if (!oprnd_info->def_stmts[j] + || STMT_VINFO_DATA_REF (oprnd_info->def_stmts[j])) + return SLP_OPRND_PATTERN_NONE; + /* Don't mix different operations. */ + if (gimple_assign_rhs_code (oprnd_info->def_stmts[j]->stmt) != code) + return SLP_OPRND_PATTERN_NONE; + } + + if (gimple_assign_rhs_code (oprnds_info[0]->def_stmts[0]->stmt) + != gimple_assign_rhs_code (oprnds_info[1]->def_stmts[0]->stmt)) + return SLP_OPRND_PATTERN_NONE; int pattern = SLP_OPRND_PATTERN_NONE; FOR_EACH_VEC_ELT (oprnds_info, i, oprnd_info)
next reply other threads:[~2024-01-23 20:58 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-23 20:58 Philipp Tomsich [this message] -- strict thread matches above, loose matches on Subject: below -- 2024-01-17 19:15 Philipp Tomsich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240123205859.5590538582B7@sourceware.org \ --to=ptomsich@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).