From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2122) id A26873858001; Wed, 24 Jan 2024 19:39:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A26873858001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1706125146; bh=R1aIPQK+hB+Y+YzS/l1deXs/n7fv6FOK5pkJT7WRqQw=; h=From:To:Subject:Date:From; b=o5ydZ2n50rjP/9VEAkE81EGamoZ2xbWtXqMY/X4Bo/Zanbk0K3Rb5WqSTZAbHAGbt mizzO6LaMagqu7Q9bh/4R+pixZAnwdWvmrXFNLPLrJKfXJlopUkHoAt75UnhEXy9D5 tUWhARR4OGkbJOvJL1Ux+crlZMNXicGREGQ6+YIY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jason Merrill To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-8248] c++: xvalue array subscript [PR103185] X-Act-Checkin: gcc X-Git-Author: Jason Merrill X-Git-Refname: refs/heads/releases/gcc-13 X-Git-Oldrev: 60bfd373a1891ae2349dc67313d104079ce8c706 X-Git-Newrev: fcc06cf83a9571a0745fcde83d955eb7d7f16910 Message-Id: <20240124193906.A26873858001@sourceware.org> Date: Wed, 24 Jan 2024 19:39:05 +0000 (GMT) List-Id: https://gcc.gnu.org/g:fcc06cf83a9571a0745fcde83d955eb7d7f16910 commit r13-8248-gfcc06cf83a9571a0745fcde83d955eb7d7f16910 Author: Jason Merrill Date: Tue Dec 19 16:12:02 2023 -0500 c++: xvalue array subscript [PR103185] Normally we handle xvalue array subscripting with ARRAY_REF, but in this case we weren't doing that because the operands were reversed. Handle that case better. PR c++/103185 gcc/cp/ChangeLog: * typeck.cc (cp_build_array_ref): Handle swapped operands. gcc/testsuite/ChangeLog: * g++.dg/cpp1z/array-prvalue2.C: New test. * g++.dg/cpp1z/eval-order3.C: Test swapped operands. (cherry picked from commit 8dfc52a75d4d6c8be1c61b4aa831b1812b14a10e) Diff: --- gcc/cp/typeck.cc | 16 +++++++++++++--- gcc/testsuite/g++.dg/cpp1z/array-prvalue2.C | 5 +++++ gcc/testsuite/g++.dg/cpp1z/eval-order3.C | 5 +++++ 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/gcc/cp/typeck.cc b/gcc/cp/typeck.cc index d448852764d..495f4fd8d03 100644 --- a/gcc/cp/typeck.cc +++ b/gcc/cp/typeck.cc @@ -3928,13 +3928,14 @@ cp_build_indirect_ref (location_t loc, tree ptr, ref_operator errorstring, If INDEX is of some user-defined type, it must be converted to integer type. Otherwise, to make a compatible PLUS_EXPR, it will inherit the type of the array, which will be some pointer type. - + LOC is the location to use in building the array reference. */ tree cp_build_array_ref (location_t loc, tree array, tree idx, tsubst_flags_t complain) { + tree first = NULL_TREE; tree ret; if (idx == 0) @@ -3979,6 +3980,14 @@ cp_build_array_ref (location_t loc, tree array, tree idx, bool non_lvalue = convert_vector_to_array_for_subscript (loc, &array, idx); + /* 0[array] */ + if (TREE_CODE (TREE_TYPE (idx)) == ARRAY_TYPE) + { + std::swap (array, idx); + if (flag_strong_eval_order == 2 && TREE_SIDE_EFFECTS (array)) + idx = first = save_expr (idx); + } + if (TREE_CODE (TREE_TYPE (array)) == ARRAY_TYPE) { tree rval, type; @@ -4054,15 +4063,16 @@ cp_build_array_ref (location_t loc, tree array, tree idx, protected_set_expr_location (ret, loc); if (non_lvalue) ret = non_lvalue_loc (loc, ret); + if (first) + ret = build2_loc (loc, COMPOUND_EXPR, TREE_TYPE (ret), first, ret); return ret; } { tree ar = cp_default_conversion (array, complain); tree ind = cp_default_conversion (idx, complain); - tree first = NULL_TREE; - if (flag_strong_eval_order == 2 && TREE_SIDE_EFFECTS (ind)) + if (!first && flag_strong_eval_order == 2 && TREE_SIDE_EFFECTS (ind)) ar = first = save_expr (ar); /* Put the integer in IND to simplify error checking. */ diff --git a/gcc/testsuite/g++.dg/cpp1z/array-prvalue2.C b/gcc/testsuite/g++.dg/cpp1z/array-prvalue2.C new file mode 100644 index 00000000000..60a038cfd16 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1z/array-prvalue2.C @@ -0,0 +1,5 @@ +// PR c++/103185 +// { dg-do compile { target c++11 } } + +using intarr = int[]; +static_assert(__is_same(decltype(0[intarr{0}]), int&&), ""); diff --git a/gcc/testsuite/g++.dg/cpp1z/eval-order3.C b/gcc/testsuite/g++.dg/cpp1z/eval-order3.C index 5773591d49f..897cdef7483 100644 --- a/gcc/testsuite/g++.dg/cpp1z/eval-order3.C +++ b/gcc/testsuite/g++.dg/cpp1z/eval-order3.C @@ -166,6 +166,11 @@ void g() ip(24)[f(25)-25] = 0; last=0; + // even with swapped operands + (f(20)-20)[afn(21)].memfn(f(22),23); + (f(24)-24)[ip(25)] = 0; + last=0; + // a << b aref(24) << f(25); iref(26) << f(27);