From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1130) id 3CEDC3858401; Thu, 25 Jan 2024 12:03:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3CEDC3858401 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1706184223; bh=fbhMYAmPd3VIUsJN2d+rSGa8aTSCnjDbGC7lks+CtLc=; h=From:To:Subject:Date:From; b=Fil8mlRNbyNxZzhmbDuuoKfQ4UEe/VgvIgV5FrSSQ6qlXbkTaB9MgrFitn6gka08k QP8x6cEoMQRvYCC94ObQdqhCj/ds0swYuqA7GkCrv6tRmot01Uq8N+IpQ8QtzuzDj6 CfAr1t2vNTaJtND7EMKRMGOJc+3vnMBc9VvG/uoM= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Sandiford To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-8422] aarch64: Fix out-of-bounds ENCODED_ELT access [PR113572] X-Act-Checkin: gcc X-Git-Author: Richard Sandiford X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 8eead1148cd0ac086b39a7abccea404041c85cb5 X-Git-Newrev: c3de14ba1ba0e77254118af64ed881f115ee42a0 Message-Id: <20240125120343.3CEDC3858401@sourceware.org> Date: Thu, 25 Jan 2024 12:03:43 +0000 (GMT) List-Id: https://gcc.gnu.org/g:c3de14ba1ba0e77254118af64ed881f115ee42a0 commit r14-8422-gc3de14ba1ba0e77254118af64ed881f115ee42a0 Author: Richard Sandiford Date: Thu Jan 25 12:03:18 2024 +0000 aarch64: Fix out-of-bounds ENCODED_ELT access [PR113572] When generalising vector_cst_all_same, I'd forgotten to update VECTOR_CST_ENCODED_ELT to VECTOR_CST_ELT. The check deliberately looks at implicitly encoded elements in some cases. gcc/ PR target/113572 * config/aarch64/aarch64-sve-builtins.cc (vector_cst_all_same): Check VECTOR_CST_ELT instead of VECTOR_CST_ENCODED_ELT gcc/testsuite/ PR target/113572 * gcc.target/aarch64/sve/pr113572.c: New test. Diff: --- gcc/config/aarch64/aarch64-sve-builtins.cc | 2 +- gcc/testsuite/gcc.target/aarch64/sve/pr113572.c | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/gcc/config/aarch64/aarch64-sve-builtins.cc b/gcc/config/aarch64/aarch64-sve-builtins.cc index c2f1486315f..11f5c5c500c 100644 --- a/gcc/config/aarch64/aarch64-sve-builtins.cc +++ b/gcc/config/aarch64/aarch64-sve-builtins.cc @@ -3474,7 +3474,7 @@ vector_cst_all_same (tree v, unsigned int step) unsigned int nelts = lcm * VECTOR_CST_NELTS_PER_PATTERN (v); tree first_el = VECTOR_CST_ENCODED_ELT (v, 0); for (unsigned int i = 0; i < nelts; i += step) - if (!operand_equal_p (VECTOR_CST_ENCODED_ELT (v, i), first_el, 0)) + if (!operand_equal_p (VECTOR_CST_ELT (v, i), first_el, 0)) return false; return true; diff --git a/gcc/testsuite/gcc.target/aarch64/sve/pr113572.c b/gcc/testsuite/gcc.target/aarch64/sve/pr113572.c new file mode 100644 index 00000000000..a5e6b7e9907 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/sve/pr113572.c @@ -0,0 +1,12 @@ +#include + +uint64_t u; +struct S { int i; } he; + +void +foo () +{ + svuint64_t vld_clz = svld1_u64 (svwhilelt_b64 (0, 4), (uint64_t *) &he); + vld_clz = svclz_u64_z (svwhilelt_b64 (0, 1), vld_clz); + svst1_u64 (svwhilelt_b64 (0, 1), &u, vld_clz); +}