From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 7D2A23858C53; Thu, 25 Jan 2024 12:16:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D2A23858C53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1706184963; bh=Ect6FGVlxNyWB0QMrjPGGQpUYDYBWbIqtEMJll68LgE=; h=From:To:Subject:Date:From; b=FtBjiwcqsz3mmmm1nIw3qGGEKHF4EnS4moVmsnDmOR1njMeKiZMC9DaSrUKuQqQhR QPyLamo9eu/fj2b/p8xvh/AORO4lSOYnuFPI6jY+eKiczhAC9CJxKCBdiTRbd1Dw0+ Tln2ZHeJZXzBOdv9gZ3NmfT22pkfJbHEIfjvrs6k= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-8423] convert: Fix test for out of bounds shift count [PR113574] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: c3de14ba1ba0e77254118af64ed881f115ee42a0 X-Git-Newrev: fb1b7e2fec951ba0bf4f68fac6a16929f4f63910 Message-Id: <20240125121603.7D2A23858C53@sourceware.org> Date: Thu, 25 Jan 2024 12:16:03 +0000 (GMT) List-Id: https://gcc.gnu.org/g:fb1b7e2fec951ba0bf4f68fac6a16929f4f63910 commit r14-8423-gfb1b7e2fec951ba0bf4f68fac6a16929f4f63910 Author: Jakub Jelinek Date: Thu Jan 25 13:15:23 2024 +0100 convert: Fix test for out of bounds shift count [PR113574] The following patch is miscompiled, because convert_to_integer_1 for LSHIFT_EXPR tests if the INTEGER_CST shift count is too high, but incorrectly compares it against TYPE_SIZE rather than TYPE_PRECISION. The type in question is unsigned _BitInt(1), which has TYPE_PRECISION 1, TYPE_SIZE 8, and the shift count is 2 in that case. 2024-01-25 Jakub Jelinek PR middle-end/113574 * convert.cc (convert_to_integer_1) : Compare shift count against TYPE_PRECISION rather than TYPE_SIZE. * gcc.dg/torture/bitint-52.c: New test. Diff: --- gcc/convert.cc | 3 ++- gcc/testsuite/gcc.dg/torture/bitint-52.c | 23 +++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/gcc/convert.cc b/gcc/convert.cc index 179f5e69008..5ad24ad2c08 100644 --- a/gcc/convert.cc +++ b/gcc/convert.cc @@ -762,7 +762,8 @@ convert_to_integer_1 (tree type, tree expr, bool dofold) { /* If shift count is less than the width of the truncated type, really shift. */ - if (tree_int_cst_lt (TREE_OPERAND (expr, 1), TYPE_SIZE (type))) + if (wi::to_widest (TREE_OPERAND (expr, 1)) + < TYPE_PRECISION (type)) /* In this case, shifting is like multiplication. */ goto trunc1; else diff --git a/gcc/testsuite/gcc.dg/torture/bitint-52.c b/gcc/testsuite/gcc.dg/torture/bitint-52.c new file mode 100644 index 00000000000..d2896da2f9a --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/bitint-52.c @@ -0,0 +1,23 @@ +/* PR middle-end/113574 */ +/* { dg-do run { target bitint } } */ +/* { dg-options "-std=c23 -pedantic-errors" } */ +/* { dg-skip-if "" { ! run_expensive_tests } { "*" } { "-O0" "-O2" } } */ +/* { dg-skip-if "" { ! run_expensive_tests } { "-flto" } { "" } } */ + +unsigned _BitInt(1) a; +unsigned _BitInt(8) b; + +void +foo (unsigned _BitInt(16) x) +{ + a += (x << 2) | b; +} + +int +main () +{ + foo (0xfef1uwb); + if (a) + __builtin_abort (); + return 0; +}