public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: LuluCheng <chenglulu@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-8446] LoongArch: Define LOGICAL_OP_NON_SHORT_CIRCUIT
Date: Fri, 26 Jan 2024 08:13:21 +0000 (GMT)	[thread overview]
Message-ID: <20240126081321.B6ADF3858C53@sourceware.org> (raw)

https://gcc.gnu.org/g:dddafe948230b4895f8d4371eee7996fb2dba44a

commit r14-8446-gdddafe948230b4895f8d4371eee7996fb2dba44a
Author: Jiahao Xu <xujiahao@loongson.cn>
Date:   Tue Jan 16 10:32:31 2024 +0800

    LoongArch: Define LOGICAL_OP_NON_SHORT_CIRCUIT
    
    Define LOGICAL_OP_NON_SHORT_CIRCUIT as 0, for a short-circuit branch, use the
    short-circuit operation instead of the non-short-circuit operation.
    
    SPEC2017 performance evaluation shows 1% performance improvement for fprate
    GEOMEAN and no obvious regression for others. Especially, 526.blender_r +10.6%
    on 3A6000.
    
    This modification will introduce the following FAIL items:
    
    FAIL: gcc.dg/tree-ssa/copy-headers-8.c scan-tree-dump-times ch2 "Conditional combines static and invariant" 1
    FAIL: gcc.dg/tree-ssa/copy-headers-8.c scan-tree-dump-times ch2 "Will duplicate bb" 2
    FAIL: gcc.dg/tree-ssa/update-threading.c scan-tree-dump-times optimized "Invalid sum" 0
    
    gcc/ChangeLog:
    
            * config/loongarch/loongarch.h (LOGICAL_OP_NON_SHORT_CIRCUIT): Define.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/loongarch/short-circuit.c: New test.

Diff:
---
 gcc/config/loongarch/loongarch.h                   |  1 +
 gcc/testsuite/gcc.target/loongarch/short-circuit.c | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h
index 4e6ede926d32..8b453ab3140d 100644
--- a/gcc/config/loongarch/loongarch.h
+++ b/gcc/config/loongarch/loongarch.h
@@ -869,6 +869,7 @@ typedef struct {
    1 is the default; other values are interpreted relative to that.  */
 
 #define BRANCH_COST(speed_p, predictable_p) la_branch_cost
+#define LOGICAL_OP_NON_SHORT_CIRCUIT 0
 
 /* Return the asm template for a conditional branch instruction.
    OPCODE is the opcode's mnemonic and OPERANDS is the asm template for
diff --git a/gcc/testsuite/gcc.target/loongarch/short-circuit.c b/gcc/testsuite/gcc.target/loongarch/short-circuit.c
new file mode 100644
index 000000000000..bed585ee1728
--- /dev/null
+++ b/gcc/testsuite/gcc.target/loongarch/short-circuit.c
@@ -0,0 +1,19 @@
+/* { dg-do compile } */
+/* { dg-options "-O2 -ffast-math -fdump-tree-gimple" } */
+
+int
+short_circuit (float *a)
+{
+  float t1x = a[0];
+  float t2x = a[1];
+  float t1y = a[2];
+  float t2y = a[3];
+  float t1z = a[4];
+  float t2z = a[5];
+
+  if (t1x > t2y  || t2x < t1y  || t1x > t2z || t2x < t1z || t1y > t2z || t2y < t1z)
+    return 0;
+
+  return 1;
+}
+/* { dg-final { scan-tree-dump-times "if" 6 "gimple" } } */

                 reply	other threads:[~2024-01-26  8:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240126081321.B6ADF3858C53@sourceware.org \
    --to=chenglulu@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).