From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7905) id F00FF3858000; Tue, 30 Jan 2024 11:58:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F00FF3858000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1706615935; bh=voJFgJ5eveprO9zPUSKdHzy+5A6kRu8sgFJDtfDbdIU=; h=From:To:Subject:Date:From; b=FcWkqwOZPSW9Wf5G1OBL26jD9Adyox3qxuUm8oN/FwPcaW7fF7qh35Td5wWIMriGf rv/NoRyeH79CDU2t48h6wqAkRYJo47PrcV1AW4ObVxX3Koi4Hq0AB87R7ScIARoVW8 ie8gsgrqMvU75Zy0KQk70PS+jjFPhDb8EM0hKzTU= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Arthur Cohen To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-8579] gccrs: Add AST validation check for const in trait X-Act-Checkin: gcc X-Git-Author: Pierre-Emmanuel Patry X-Git-Refname: refs/heads/trunk X-Git-Oldrev: ac501a75b263a7dd7fa437c01aae53d41e30a515 X-Git-Newrev: 9279483f6e87258e36345c355720860925a75e3e Message-Id: <20240130115855.F00FF3858000@sourceware.org> Date: Tue, 30 Jan 2024 11:58:55 +0000 (GMT) List-Id: https://gcc.gnu.org/g:9279483f6e87258e36345c355720860925a75e3e commit r14-8579-g9279483f6e87258e36345c355720860925a75e3e Author: Pierre-Emmanuel Patry Date: Wed Nov 22 13:08:13 2023 +0100 gccrs: Add AST validation check for const in trait Add a new check in AST validation pass that checks that no function declaration in traits are declared const. gcc/rust/ChangeLog: * checks/errors/rust-ast-validation.cc (ASTValidation::visit): Add const check. * checks/errors/rust-ast-validation.h: Add visit function prototype. Signed-off-by: Pierre-Emmanuel Patry Diff: --- gcc/rust/checks/errors/rust-ast-validation.cc | 10 ++++++++++ gcc/rust/checks/errors/rust-ast-validation.h | 1 + 2 files changed, 11 insertions(+) diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc index 54276e8fd599..2743eb0ca299 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.cc +++ b/gcc/rust/checks/errors/rust-ast-validation.cc @@ -117,6 +117,16 @@ ASTValidation::visit (AST::Function &function) AST::ContextualASTVisitor::visit (function); } +void +ASTValidation::visit (AST::TraitFunctionDecl &decl) +{ + const auto &qualifiers = decl.get_qualifiers (); + + if (context.back () == Context::TRAIT && qualifiers.is_const ()) + rust_error_at (decl.get_identifier ().get_locus (), ErrorCode::E0379, + "functions in traits cannot be declared const"); +} + void ASTValidation::visit (AST::Trait &trait) { diff --git a/gcc/rust/checks/errors/rust-ast-validation.h b/gcc/rust/checks/errors/rust-ast-validation.h index 01d923ceff33..963357f86cd8 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.h +++ b/gcc/rust/checks/errors/rust-ast-validation.h @@ -42,6 +42,7 @@ public: virtual void visit (AST::Union &item); virtual void visit (AST::Function &function); virtual void visit (AST::Trait &trait); + virtual void visit (AST::TraitFunctionDecl &decl); }; } // namespace Rust