public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-8661] hwasan: Remove testsuite check for a complaint message [PR112644]
@ 2024-01-31 14:52 Tamar Christina
  0 siblings, 0 replies; only message in thread
From: Tamar Christina @ 2024-01-31 14:52 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:0a640455928a050315f6addd88ace5d945eba130

commit r14-8661-g0a640455928a050315f6addd88ace5d945eba130
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Jan 31 14:51:36 2024 +0000

    hwasan: Remove testsuite check for a complaint message [PR112644]
    
    With recent updates to hwasan runtime libraries, the error reporting for
    this particular check is has been reworked.
    
    I would question why it has lost this message.  To me it looks strange
    that num_descriptions_printed is incremented whenever we call
    PrintHeapOrGlobalCandidate whether that function prints anything or not.
    (See PrintAddressDescription in libsanitizer/hwasan/hwasan_report.cpp).
    
    The message is no longer printed because we increment this
    num_descriptions_printed variable indicating that we have found some
    description.
    
    I would like to question this upstream, but it doesn't look that much of
    a problem and if pressed for time we should just change our testsuite.
    Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
    
    gcc/testsuite/ChangeLog:
    
            PR sanitizer/112644
            * c-c++-common/hwasan/hwasan-thread-clears-stack.c: Update testcase.

Diff:
---
 gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c b/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
index 09c72a56f0f5..6c70684d72a8 100644
--- a/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
+++ b/gcc/testsuite/c-c++-common/hwasan/hwasan-thread-clears-stack.c
@@ -52,5 +52,4 @@ main (int argc, char **argv)
 
 /* { dg-output "HWAddressSanitizer: tag-mismatch on address 0x\[0-9a-f\]*.*" } */
 /* { dg-output "READ of size 4 at 0x\[0-9a-f\]* tags: \[\[:xdigit:\]\]\[\[:xdigit:\]\]/00 \\(ptr/mem\\) in thread T0.*" } */
-/* { dg-output "HWAddressSanitizer can not describe address in more detail\..*" } */
 /* { dg-output "SUMMARY: HWAddressSanitizer: tag-mismatch \[^\n\]*.*" } */

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-01-31 14:52 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-31 14:52 [gcc r14-8661] hwasan: Remove testsuite check for a complaint message [PR112644] Tamar Christina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).