public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Rainer Orth <ro@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-8930] libgomp: testsuite: Don't XPASS libgomp.c/alloc-pinned-1.c etc. on non-Linux targets [PR113448]
Date: Mon, 12 Feb 2024 13:45:07 +0000 (GMT)	[thread overview]
Message-ID: <20240212134507.C9F2B3858C98@sourceware.org> (raw)

https://gcc.gnu.org/g:1e94648ab7b370c5867e146c7f59603e2e6ba2e6

commit r14-8930-g1e94648ab7b370c5867e146c7f59603e2e6ba2e6
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Mon Feb 12 14:44:17 2024 +0100

    libgomp: testsuite: Don't XPASS libgomp.c/alloc-pinned-1.c etc. on non-Linux targets [PR113448]
    
    Two libgomp tests XPASS on Solaris (any non-Linux target actually) since
    their introduction:
    
    XPASS: libgomp.c/alloc-pinned-1.c execution test
    XPASS: libgomp.c/alloc-pinned-2.c execution test
    
    The problem is that the test just prints
    
    OS unsupported
    
    and exits successfully, while the test is XFAILed:
    
    /* { dg-xfail-run-if "Pinning not implemented on this host" { ! *-*-linux-gnu } } */
    
    Fixed by aborting immediately after the message above in the non-Linux
    case.
    
    Tested on i386-pc-solaris2.11 and i686-pc-linux-gnu.
    
    2024-02-02  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
    
            libgomp:
            PR testsuite/113448
            * testsuite/libgomp.c/alloc-pinned-1.c [!__linux__] (CHECK_SIZE):
            Call abort.
            * testsuite/libgomp.c/alloc-pinned-2.c [!__linux__] (CHECK_SIZE):
            Likewise.

Diff:
---
 libgomp/testsuite/libgomp.c/alloc-pinned-1.c | 5 ++++-
 libgomp/testsuite/libgomp.c/alloc-pinned-2.c | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/libgomp/testsuite/libgomp.c/alloc-pinned-1.c b/libgomp/testsuite/libgomp.c/alloc-pinned-1.c
index e17a21f0a6c0..4185accf2e65 100644
--- a/libgomp/testsuite/libgomp.c/alloc-pinned-1.c
+++ b/libgomp/testsuite/libgomp.c/alloc-pinned-1.c
@@ -45,7 +45,10 @@ get_pinned_mem ()
 }
 #else
 #define PAGE_SIZE 1024 /* unknown */
-#define CHECK_SIZE(SIZE) fprintf (stderr, "OS unsupported\n");
+#define CHECK_SIZE(SIZE) { \
+  fprintf (stderr, "OS unsupported\n"); \
+  abort (); \
+  }
 #define EXPECT_OMP_NULL_ALLOCATOR
 
 int
diff --git a/libgomp/testsuite/libgomp.c/alloc-pinned-2.c b/libgomp/testsuite/libgomp.c/alloc-pinned-2.c
index 3cf322cfbc86..0b9c11d03158 100644
--- a/libgomp/testsuite/libgomp.c/alloc-pinned-2.c
+++ b/libgomp/testsuite/libgomp.c/alloc-pinned-2.c
@@ -45,7 +45,10 @@ get_pinned_mem ()
 }
 #else
 #define PAGE_SIZE 1024 /* unknown */
-#define CHECK_SIZE(SIZE) fprintf (stderr, "OS unsupported\n");
+#define CHECK_SIZE(SIZE) { \
+  fprintf (stderr, "OS unsupported\n"); \
+  abort (); \
+  }
 #define EXPECT_OMP_NULL_ALLOCATOR
 
 int

                 reply	other threads:[~2024-02-12 13:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212134507.C9F2B3858C98@sourceware.org \
    --to=ro@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).