From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2122) id 507C7385828B; Tue, 13 Feb 2024 16:15:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 507C7385828B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1707840945; bh=G9XEVZAgc2AOkKbdDrDNGCUJsDanymYWz2hzR3Ztgg8=; h=From:To:Subject:Date:From; b=UdFJPMCnM6WyUVFvPVha3eRmB8bPLAVf4ykLGQ2HDWfmahzJ1jpS7OMWK1eGPrblw FmxEaJI5uI6y/M3hivKAL77TqpHtieKvDX1fOUkpMQLt6koQk0aUSHlrGQfB8K6ls1 BuevgjmTzMnB5IpiZIW3QPHfNwVgIIPvtAfH6LLQ= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jason Merrill To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-8960] c++: variable partial spec redeclaration [PR113612] X-Act-Checkin: gcc X-Git-Author: Jason Merrill X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 7eac19be5f7dd92fcbcfe13f6edbb4f9bd45c15c X-Git-Newrev: 19ac327de421fe05916e234e3450e6e1cc5c935c Message-Id: <20240213161545.507C7385828B@sourceware.org> Date: Tue, 13 Feb 2024 16:15:45 +0000 (GMT) List-Id: https://gcc.gnu.org/g:19ac327de421fe05916e234e3450e6e1cc5c935c commit r14-8960-g19ac327de421fe05916e234e3450e6e1cc5c935c Author: Jason Merrill Date: Mon Feb 12 21:00:53 2024 -0500 c++: variable partial spec redeclaration [PR113612] If register_specialization finds a previous declaration and throws the new one away, we shouldn't still add the new one to DECL_TEMPLATE_SPECIALIZATIONS. PR c++/113612 gcc/cp/ChangeLog: * pt.cc (process_partial_specialization): Return early on redeclaration. gcc/testsuite/ChangeLog: * g++.dg/cpp1y/var-templ85.C: New test. Diff: --- gcc/cp/pt.cc | 11 ++++++++--- gcc/testsuite/g++.dg/cpp1y/var-templ85.C | 6 ++++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc index 475f2181cc49..2803824d11e1 100644 --- a/gcc/cp/pt.cc +++ b/gcc/cp/pt.cc @@ -5417,9 +5417,14 @@ process_partial_specialization (tree decl) } if (VAR_P (decl)) - /* We didn't register this in check_explicit_specialization so we could - wait until the constraints were set. */ - decl = register_specialization (decl, maintmpl, specargs, false, 0); + { + /* We didn't register this in check_explicit_specialization so we could + wait until the constraints were set. */ + tree reg = register_specialization (decl, maintmpl, specargs, false, 0); + if (reg != decl) + /* Redeclaration. */ + return reg; + } else associate_classtype_constraints (type); diff --git a/gcc/testsuite/g++.dg/cpp1y/var-templ85.C b/gcc/testsuite/g++.dg/cpp1y/var-templ85.C new file mode 100644 index 000000000000..33c24e0c2844 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1y/var-templ85.C @@ -0,0 +1,6 @@ +// PR c++/113612 +// { dg-do compile { target c++14 } } + +template T t; +template extern T *t; +template T *t = t;