From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1039) id 6E40C3857C5B; Tue, 13 Feb 2024 20:05:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6E40C3857C5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1707854723; bh=wKNfHKGQ1rmoX/PXpGsQDGNsJ98R+SO07PhVaDrc0Os=; h=From:To:Subject:Date:From; b=cT2DtsR2noMVDiXCeJihyGZGXV+3jKsMYX6uGPvc4DZFg9dR9u/Vka2OZnXF0MtQN lMW8oIvY61I2nt2PFCeqPBFG2fLvmRBRK9ak8YhuXgEFxQzW8yxMBZ74B520ykG5q6 3Wbqprr8SZgr8drJow+JI+FCPRPAmgdO4RGDKU4s= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: H.J. Lu To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-8966] x86-64: Use push2/pop2 only if the incoming stack is 16-byte aligned X-Act-Checkin: gcc X-Git-Author: H.J. Lu X-Git-Refname: refs/heads/master X-Git-Oldrev: a5d34b60c949e85aa3e213872fbc42f4eee7457b X-Git-Newrev: ab71fd7ac7a2307723117c796e7ae4d7e9711058 Message-Id: <20240213200523.6E40C3857C5B@sourceware.org> Date: Tue, 13 Feb 2024 20:05:22 +0000 (GMT) List-Id: https://gcc.gnu.org/g:ab71fd7ac7a2307723117c796e7ae4d7e9711058 commit r14-8966-gab71fd7ac7a2307723117c796e7ae4d7e9711058 Author: H.J. Lu Date: Tue Feb 13 11:58:00 2024 -0800 x86-64: Use push2/pop2 only if the incoming stack is 16-byte aligned Since push2/pop2 requires 16-byte stack alignment, don't use them if the incoming stack isn't 16-byte aligned. gcc/ PR target/113876 * config/i386/i386.cc (ix86_pro_and_epilogue_can_use_push2pop2): Return false if the incoming stack isn't 16-byte aligned. gcc/testsuite/ PR target/113876 * gcc.target/i386/pr113876.c: New test. Diff: --- gcc/config/i386/i386.cc | 6 ++++++ gcc/testsuite/gcc.target/i386/pr113876.c | 10 ++++++++++ 2 files changed, 16 insertions(+) diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index dbb26e8f76ab..a4e12602f704 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -6807,6 +6807,12 @@ get_probe_interval (void) static bool ix86_pro_and_epilogue_can_use_push2pop2 (int nregs) { + /* Use push2/pop2 only if the incoming stack is 16-byte aligned. */ + unsigned int incoming_stack_boundary + = (crtl->parm_stack_boundary > ix86_incoming_stack_boundary + ? crtl->parm_stack_boundary : ix86_incoming_stack_boundary); + if (incoming_stack_boundary % 128 != 0) + return false; int aligned = cfun->machine->fs.sp_offset % 16 == 0; return TARGET_APX_PUSH2POP2 && !cfun->machine->frame.save_regs_using_mov diff --git a/gcc/testsuite/gcc.target/i386/pr113876.c b/gcc/testsuite/gcc.target/i386/pr113876.c new file mode 100644 index 000000000000..fbf26f6ab8f2 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr113876.c @@ -0,0 +1,10 @@ +/* { dg-do compile { target { lp64 } } } */ +/* { dg-options "-O -mapxf -mpreferred-stack-boundary=3 -finstrument-functions -mcmodel=large" } */ + +void +bar (unsigned long *p) +{ + p[0] = 0; + p[1] = 0; + p[2] = 0; +}