public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Rainer Orth <ro@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-8971] testsuite: xfail c-c++-common/pr103798-2.c for C++ on Solaris [PR113706]
Date: Wed, 14 Feb 2024 08:25:48 +0000 (GMT)	[thread overview]
Message-ID: <20240214082549.0A070385782C@sourceware.org> (raw)

https://gcc.gnu.org/g:ab0c2c367a87b03f38a486a118b89335837619dc

commit r14-8971-gab0c2c367a87b03f38a486a118b89335837619dc
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Wed Feb 14 09:25:03 2024 +0100

    testsuite: xfail c-c++-common/pr103798-2.c for C++ on Solaris [PR113706]
    
    c-c++-common/pr103798-2.c FAILs on Solaris when compiled as C++:
    
    FAIL: c-c++-common/pr103798-2.c  -std=gnu++14  scan-assembler-not memchr
    FAIL: c-c++-common/pr103798-2.c  -std=gnu++17  scan-assembler-not memchr
    FAIL: c-c++-common/pr103798-2.c  -std=gnu++20  scan-assembler-not memchr
    FAIL: c-c++-common/pr103798-2.c  -std=gnu++98  scan-assembler-not memchr
    
    As Jason analyzed, Solaris <string.h> declares memchr for C++ as returning
    const void * as specified by the C++ standard, while gcc expects the return
    type to be void * like in C.
    
    So this patch xfails the test for C++ on Solaris.
    
    Tested on sparc-sun-solaris2.11 and x86_64-pc-linux-gnu.
    
    2024-02-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
    
            gcc/testsuite:
            PR c++/113706
            * c-c++-common/pr103798-2.c (scan-assembler-not): xfail for C++ on
            Solaris.

Diff:
---
 gcc/testsuite/c-c++-common/pr103798-2.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/c-c++-common/pr103798-2.c b/gcc/testsuite/c-c++-common/pr103798-2.c
index e7e99c3679ec..bc126c205e1e 100644
--- a/gcc/testsuite/c-c++-common/pr103798-2.c
+++ b/gcc/testsuite/c-c++-common/pr103798-2.c
@@ -27,4 +27,5 @@ main ()
  return 0;
 }
 
-/* { dg-final { scan-assembler-not "memchr" } } */
+/* See PR c++/113706 for the xfail.  */
+/* { dg-final { scan-assembler-not "memchr" { xfail { c++ && *-*-solaris2* } } } } */

                 reply	other threads:[~2024-02-14  8:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240214082549.0A070385782C@sourceware.org \
    --to=ro@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).