public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-8978] vect/testsuite: Fix vect-simd-clone-1[02].c when dg-do default is compile [PR113899]
Date: Wed, 14 Feb 2024 13:41:53 +0000 (GMT)	[thread overview]
Message-ID: <20240214134155.441FE385DC30@sourceware.org> (raw)

https://gcc.gnu.org/g:948dbc5ee45f9ffd5f41fd6782704081cc7c8c27

commit r14-8978-g948dbc5ee45f9ffd5f41fd6782704081cc7c8c27
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Tue Feb 13 13:39:16 2024 -0800

    vect/testsuite: Fix vect-simd-clone-1[02].c when dg-do default is compile [PR113899]
    
    The vect testsuite will chose the dg-do default based on if it knows the
    running target does not support running with the vector extensions enabled
    (for easy of testing). The problem is when it is decided the default is compile
    instead of run, dg-additional-sources does not work. So the fix is to set
    dg-do on these two testcases to run explicitly.
    
    Tested on x86_64 with a hack to check_vect_support_and_set_flags to set the dg-default
    to compile.
    
    gcc/testsuite/ChangeLog:
    
            PR testsuite/113899
            * gcc.dg/vect/vect-simd-clone-10.c: Add `dg-do run`
            * gcc.dg/vect/vect-simd-clone-12.c: Likewise.
    
    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

Diff:
---
 gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c | 2 ++
 gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c
index ed63ff59cc05..009c849b7e7e 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c
@@ -1,3 +1,5 @@
+/* Since this uses dg-additional-sources, need to specify `dg-do run` instead of the default. */
+/* { dg-do run } */
 /* { dg-require-effective-target vect_simd_clones } */
 /* { dg-additional-options "-fopenmp-simd" } */
 /* { dg-additional-options "-mavx" { target avx_runtime } } */
diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c
index c44471e35bc1..4699a3f3c800 100644
--- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c
+++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c
@@ -1,3 +1,5 @@
+/* Since this uses dg-additional-sources, need to specify `dg-do run` instead of the default. */
+/* { dg-do run } */
 /* { dg-require-effective-target vect_simd_clones } */
 /* { dg-additional-options "-fopenmp-simd" } */
 /* { dg-additional-options "-mavx" { target avx_runtime } } */

                 reply	other threads:[~2024-02-14 13:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240214134155.441FE385DC30@sourceware.org \
    --to=pinskia@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).