public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jerry DeLisle <jvdelisle@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-8983] Fortran: Implement read_x for UTF-8 encoded files.
Date: Wed, 14 Feb 2024 15:58:40 +0000 (GMT)	[thread overview]
Message-ID: <20240214155840.B55F9385840C@sourceware.org> (raw)

https://gcc.gnu.org/g:b79d3e6a9284703b70688122f7d4955e7c50804a

commit r14-8983-gb79d3e6a9284703b70688122f7d4955e7c50804a
Author: Jerry DeLisle <jvdelisle@gcc.gnu.org>
Date:   Tue Feb 13 14:32:21 2024 -0800

    Fortran: Implement read_x for UTF-8 encoded files.
    
            PR fortran/99210
    
    libgfortran/ChangeLog:
    
            * io/read.c (read_x): If UTF-8 encoding is enabled, use
            read_utf8 to move one character over in the read buffer.
    
    gcc/testsuite/ChangeLog:
    
            * gfortran.dg/pr99210.f90: New test.

Diff:
---
 gcc/testsuite/gfortran.dg/pr99210.f90 | 29 +++++++++++++++++++++++++++++
 libgfortran/io/read.c                 | 17 +++++++++++++++++
 2 files changed, 46 insertions(+)

diff --git a/gcc/testsuite/gfortran.dg/pr99210.f90 b/gcc/testsuite/gfortran.dg/pr99210.f90
new file mode 100644
index 000000000000..9fd2fb468df0
--- /dev/null
+++ b/gcc/testsuite/gfortran.dg/pr99210.f90
@@ -0,0 +1,29 @@
+! { dg-do run }
+! PR99210 X editing for reading file with encoding='utf-8'
+program test_bug_format_x
+  use iso_fortran_env
+  integer, parameter :: u = selected_char_kind('ISO_10646')
+
+  character(kind=u, len=1) a, b, a1, b1, b2
+
+  open(unit=10, file='test_bug_format_x.tmp', encoding='UTF-8')
+
+  a = char(int(z'03B1'), u)
+  b = char(int(z'03B2'), u)
+  write(10, '(a1, a1)') a, b
+
+  rewind(10)
+  read(10, '(a1, a1)') a1, b1
+
+  rewind(10)
+  read(10, '(1x, a1)') b2
+
+  close (10, status="delete")
+  if(a /= a1 .or. b /= b1) then
+    error stop 1
+  end if
+
+  if(b /= b2) then
+    error stop 2
+  end if
+end program test_bug_format_x
diff --git a/libgfortran/io/read.c b/libgfortran/io/read.c
index 0ffcf76fd387..e2d2f8be8065 100644
--- a/libgfortran/io/read.c
+++ b/libgfortran/io/read.c
@@ -1307,6 +1307,23 @@ read_x (st_parameter_dt *dtp, size_t n)
     
   if (n == 0)
     return;
+    
+  if (dtp->u.p.current_unit->flags.encoding == ENCODING_UTF8)
+    {
+      gfc_char4_t c;
+      size_t nbytes, j;
+    
+      /* Proceed with decoding one character at a time.  */
+      for (j = 0; j < n; j++)
+	{
+	  c = read_utf8 (dtp, &nbytes);
+    
+	  /* Check for a short read and if so, break out.  */
+	  if (nbytes == 0 || c == (gfc_char4_t)0)
+	    break;
+	}
+      return;
+    }
 
   length = n;

                 reply	other threads:[~2024-02-14 15:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240214155840.B55F9385840C@sourceware.org \
    --to=jvdelisle@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).