From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 6497E384DB61; Thu, 15 Feb 2024 12:57:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6497E384DB61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708001822; bh=4eKekgnaZtA1OT1kyjS5HZzzCivFetVPSrPTC5WqHKM=; h=From:To:Subject:Date:From; b=jGgiXv/RW/S+86tf94DRwVIeK2fbGGvmFtbYdi6aJWdM9f91nhFroWWXXWo6D5Kx6 ctbnwSzz2lCC9Vb74LYq1YZ9E3Hdlq9D3sEzeSxeUcyXmL8LtlHMbxgUIbVI3f1Pt5 XNq9FWOFaePi/tL3VX+7uDsgVIsijjUiwliEdv4s= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-9007] gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: 5329b94188206e9f8c96d9a63931c415fa5d39d7 X-Git-Newrev: f0b1cf01782ba975cfda32800c91076df78058d6 Message-Id: <20240215125702.6497E384DB61@sourceware.org> Date: Thu, 15 Feb 2024 12:57:02 +0000 (GMT) List-Id: https://gcc.gnu.org/g:f0b1cf01782ba975cfda32800c91076df78058d6 commit r14-9007-gf0b1cf01782ba975cfda32800c91076df78058d6 Author: Jakub Jelinek Date: Thu Feb 15 13:55:49 2024 +0100 gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead On Fri, Feb 09, 2024 at 11:03:38AM +0100, Jakub Jelinek wrote: > On Wed, Feb 07, 2024 at 12:43:59PM +0100, arthur.cohen@embecosm.com wrote: > > This patch introduces one regression because generics are getting better > > understood over time. The code here used to apply generics with the same > > symbol from previous segments which was a bit of a hack with out limited > > inference variable support. The regression looks like it will be related > > to another issue which needs to default integer inference variables much > > more aggresivly to default integer. > > > > Fixes #2723 > > * rust/compile/issue-1773.rs: Moved to... > > * rust/compile/issue-1773.rs.bak: ...here. > > Please don't use such suffixes in the testsuite. > Either delete the testcase, or xfail it somehow until the bug is fixed. To be precise, I have scripts to look for backup files in the tree (*~, *.bak, *.orig, *.rej etc.) and this stands in the way several times a day. Here is a fix for that in patch form, tested on x86_64-linux with make check-rust RUNTESTFLAGS='compile.exp=issue-1773.rs' 2024-02-15 Jakub Jelinek * rust/compile/issue-1773.rs.bak: Rename to ... * rust/compile/issue-1773.rs: ... this. Add dg-skip-if directive. Diff: --- gcc/testsuite/rust/compile/{issue-1773.rs.bak => issue-1773.rs} | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/testsuite/rust/compile/issue-1773.rs.bak b/gcc/testsuite/rust/compile/issue-1773.rs similarity index 89% rename from gcc/testsuite/rust/compile/issue-1773.rs.bak rename to gcc/testsuite/rust/compile/issue-1773.rs index a4542aea00b0..468497a4792e 100644 --- a/gcc/testsuite/rust/compile/issue-1773.rs.bak +++ b/gcc/testsuite/rust/compile/issue-1773.rs @@ -1,4 +1,5 @@ #[lang = "sized"] +// { dg-skip-if "" { *-*-* } } pub trait Sized {} trait Foo {