From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id C93553858D35; Mon, 19 Feb 2024 20:40:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C93553858D35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708375252; bh=JVYF7PLE8iKXAIqoazFVYv/ReW/NEHxx6Wtkl3R+3r0=; h=From:To:Subject:Date:From; b=iyFHZk9Ldtkqe9+2XwjeuEGwU5/GBpHI3a3ktDVkwnu6D8pYmZUJ+r/skqdM61sqa xCJYyrAusjm/EgscPChgAICfoV1XVAQXnVQQLPptVSZFN5O95RQs3tIU4Rxqd8xanJ DfY6YOTsupz3uyCVE0aw1LGjPbJj3Wi65rXOz+GM= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-9074] analyzer: Fix maybe_undo_optimize_bit_field_compare vs non-scalar types [PR113983] X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 1609fdff16f17ead37666f6d0e801800ee3d04d2 X-Git-Newrev: d70facd54a576faca1bfba96e92e1475e0da22a3 Message-Id: <20240219204052.C93553858D35@sourceware.org> Date: Mon, 19 Feb 2024 20:40:52 +0000 (GMT) List-Id: https://gcc.gnu.org/g:d70facd54a576faca1bfba96e92e1475e0da22a3 commit r14-9074-gd70facd54a576faca1bfba96e92e1475e0da22a3 Author: Andrew Pinski Date: Sun Feb 18 14:14:23 2024 -0800 analyzer: Fix maybe_undo_optimize_bit_field_compare vs non-scalar types [PR113983] After r14-6419-g4eaaf7f5a378e8, maybe_undo_optimize_bit_field_compare would ICE on vector CST but this function really should be checking if we had integer types so reject non-integral types early on (like it was doing for non-char type before r14-6419-g4eaaf7f5a378e8). Committed as obvious after build and tested for aarch64-linux-gnu with no regressions. PR analyzer/113983 gcc/analyzer/ChangeLog: * region-model-manager.cc (maybe_undo_optimize_bit_field_compare): Reject non integral types. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/torture/vector-extract-1.c: New test. Signed-off-by: Andrew Pinski Diff: --- gcc/analyzer/region-model-manager.cc | 3 +++ gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c | 14 ++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/gcc/analyzer/region-model-manager.cc b/gcc/analyzer/region-model-manager.cc index 62f808a81c20..21e13b480257 100644 --- a/gcc/analyzer/region-model-manager.cc +++ b/gcc/analyzer/region-model-manager.cc @@ -602,6 +602,9 @@ maybe_undo_optimize_bit_field_compare (tree type, tree cst, const svalue *arg1) { + if (!INTEGRAL_TYPE_P (type)) + return NULL; + const binding_map &map = compound_sval->get_map (); unsigned HOST_WIDE_INT mask = TREE_INT_CST_LOW (cst); /* If "mask" is a contiguous range of set bits, see if the diff --git a/gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c b/gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c new file mode 100644 index 000000000000..5b878e6e4e21 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c @@ -0,0 +1,14 @@ +/* PR analyzer/113983 */ + +/* maybe_undo_optimize_bit_field_compare used to ICE on this + because it was not checking for only integer types. */ + +typedef int __attribute__((__vector_size__(8))) V; +int i; + +V +foo(void) +{ + V v = (V){}; + return (0, 0) * (i & v); +}