From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1130) id A434F3858C24; Wed, 21 Feb 2024 11:13:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A434F3858C24 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708513988; bh=5baQEmeQYPLyXGfmx8oTtbQjFyxRQ6p9HnWmRzeEVqQ=; h=From:To:Subject:Date:From; b=ZkLOctqMCU6+65ksu9qG83DAYS8jKhk0wan+61uCg+Dvt74COBBk2URGAGim6RDlq 6la00XNjnegK0oNpqDRU6JDjnzDPhgwc1ixvxukn+2JbuEcH9cyOnkz5dLljVEjiVZ b14A3mni1xoGD+rWH1bEqVAOoFwdpPo1HDUvBowk= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Sandiford To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-9100] aarch64: Ensure ZT0 is zeroed in a new-ZT0 function X-Act-Checkin: gcc X-Git-Author: Richard Sandiford X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 58930e9fd1816c2a71c4f4e54a82e870d3afe10a X-Git-Newrev: 22f0cf36ec0ad4ec76b50cd87eaab925bda74df8 Message-Id: <20240221111308.A434F3858C24@sourceware.org> Date: Wed, 21 Feb 2024 11:13:08 +0000 (GMT) List-Id: https://gcc.gnu.org/g:22f0cf36ec0ad4ec76b50cd87eaab925bda74df8 commit r14-9100-g22f0cf36ec0ad4ec76b50cd87eaab925bda74df8 Author: Richard Sandiford Date: Wed Feb 21 11:12:28 2024 +0000 aarch64: Ensure ZT0 is zeroed in a new-ZT0 function ACLE guarantees that a function like: __arm_new("zt0") foo() { ... } will start with ZT0 equal to zero. I'd forgotten to enforce that after commiting a lazy save. After such a save, we should zero ZA iff the function has ZA state and zero ZT0 iff the function has ZT0 state. gcc/ * config/aarch64/aarch64.cc (aarch64_mode_emit_local_sme_state): In the code that commits a lazy save, only zero ZA if the function has ZA state. Similarly zero ZT0 if the function has ZT0 state. gcc/testsuite/ * gcc.target/aarch64/sme/zt0_state_5.c (test3): Expect ZT0 rather than ZA to be zeroed. (test5): Remove zeroing of ZA. Diff: --- gcc/config/aarch64/aarch64.cc | 8 +++++++- gcc/testsuite/gcc.target/aarch64/sme/zt0_state_5.c | 3 +-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc index ed7fbca512bb..de746e28ca5a 100644 --- a/gcc/config/aarch64/aarch64.cc +++ b/gcc/config/aarch64/aarch64.cc @@ -29338,6 +29338,7 @@ aarch64_mode_emit_local_sme_state (aarch64_local_sme_state mode, bl __arm_tpidr2_save msr tpidr2_el0, xzr zero { za } // Only if ZA is live + zero { zt0 } // Only if ZT0 is live no_save: */ auto tmp_reg = gen_reg_rtx (DImode); emit_insn (gen_aarch64_read_tpidr2 (tmp_reg)); @@ -29348,7 +29349,12 @@ aarch64_mode_emit_local_sme_state (aarch64_local_sme_state mode, emit_insn (gen_aarch64_clear_tpidr2 ()); if (mode == aarch64_local_sme_state::ACTIVE_LIVE || mode == aarch64_local_sme_state::ACTIVE_DEAD) - emit_insn (gen_aarch64_initial_zero_za ()); + { + if (aarch64_cfun_has_state ("za")) + emit_insn (gen_aarch64_initial_zero_za ()); + if (aarch64_cfun_has_state ("zt0")) + emit_insn (gen_aarch64_sme_zero_zt0 ()); + } emit_label (label); } diff --git a/gcc/testsuite/gcc.target/aarch64/sme/zt0_state_5.c b/gcc/testsuite/gcc.target/aarch64/sme/zt0_state_5.c index 0fba21868ed3..2e008463aecc 100644 --- a/gcc/testsuite/gcc.target/aarch64/sme/zt0_state_5.c +++ b/gcc/testsuite/gcc.target/aarch64/sme/zt0_state_5.c @@ -54,7 +54,7 @@ __arm_new("zt0") int test3() ** cbz x0, [^\n]+ ** bl __arm_tpidr2_save ** msr tpidr2_el0, xzr -** zero { za } +** zero { zt0 } ** smstart za ** bl in_zt0 ** smstop za @@ -102,7 +102,6 @@ __arm_new("zt0") void test5() ** cbz x0, [^\n]+ ** bl __arm_tpidr2_save ** msr tpidr2_el0, xzr -** zero { za } ** smstart za ** bl out_zt0 ** ...