From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1984) id 1F4523858D34; Wed, 21 Feb 2024 11:44:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F4523858D34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708515841; bh=PPN+BoQrW++weiJgbOfvpWwqlJTf1YElDTGJSFpES5Q=; h=From:To:Subject:Date:From; b=bkwcg4ir2yBaRSwafLCamyRsNeT0TqhhEHCBmw1jQJqYiELKggaO+/DJ+tA6IM/2e dxRwezMCzLDJs5RbpWB8uGnPh9ZU8AgBjhZaBerU3cpQsNg7ahqYTqE1mZlZu96l4C P6VC2ihSF4S0FSOXdGgH6f5Dlm8FaA6N7S6fVLcY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Tamar Christina To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-9105] AArch64: remove ls64 from being mandatory on armv8.7-a.. X-Act-Checkin: gcc X-Git-Author: Tamar Christina X-Git-Refname: refs/heads/master X-Git-Oldrev: c8c587b854c9e85fc9ce58c8192d532205f0ee1f X-Git-Newrev: d0f8cb17bbd35e5eb25fc3b2119756b3e103e798 Message-Id: <20240221114401.1F4523858D34@sourceware.org> Date: Wed, 21 Feb 2024 11:44:00 +0000 (GMT) List-Id: https://gcc.gnu.org/g:d0f8cb17bbd35e5eb25fc3b2119756b3e103e798 commit r14-9105-gd0f8cb17bbd35e5eb25fc3b2119756b3e103e798 Author: Tamar Christina Date: Wed Feb 21 11:42:53 2024 +0000 AArch64: remove ls64 from being mandatory on armv8.7-a.. The Arm Architectural Reference Manual (Version J.a, section A2.9 on FEAT_LS64) shows that ls64 is an optional extensions and should not be enabled by default for Armv8.7-a. This drops it from the mandatory bits for the architecture and brings GCC inline with LLVM and the achitecture. Note that we will not be changing binutils to preserve compatibility with older released compilers. gcc/ChangeLog: * config/aarch64/aarch64-arches.def (AARCH64_ARCH): Remove LS64 from Armv8.7-a. gcc/testsuite/ChangeLog: * g++.target/aarch64/acle/ls64.C: Add +ls64. * g++.target/aarch64/acle/ls64_lto.C: Likewise. * gcc.target/aarch64/acle/ls64_lto.c: Likewise. * gcc.target/aarch64/acle/pr110100.c: Likewise. * gcc.target/aarch64/acle/pr110132.c: Likewise. * gcc.target/aarch64/options_set_28.c: Drop check for nols64. * gcc.target/aarch64/pragma_cpp_predefs_2.c: Correct header checks. Diff: --- gcc/config/aarch64/aarch64-arches.def | 2 +- gcc/testsuite/g++.target/aarch64/acle/ls64.C | 2 +- gcc/testsuite/g++.target/aarch64/acle/ls64_lto.C | 2 +- gcc/testsuite/gcc.target/aarch64/acle/ls64_lto.c | 2 +- gcc/testsuite/gcc.target/aarch64/acle/pr110100.c | 2 +- gcc/testsuite/gcc.target/aarch64/acle/pr110132.c | 2 +- gcc/testsuite/gcc.target/aarch64/options_set_28.c | 4 ++-- gcc/testsuite/gcc.target/aarch64/pragma_cpp_predefs_2.c | 4 ++-- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/gcc/config/aarch64/aarch64-arches.def b/gcc/config/aarch64/aarch64-arches.def index b7115ff7c3d4..9bec30e9203b 100644 --- a/gcc/config/aarch64/aarch64-arches.def +++ b/gcc/config/aarch64/aarch64-arches.def @@ -37,7 +37,7 @@ AARCH64_ARCH("armv8.3-a", generic_armv8_a, V8_3A, 8, (V8_2A, PAUTH, R AARCH64_ARCH("armv8.4-a", generic_armv8_a, V8_4A, 8, (V8_3A, F16FML, DOTPROD, FLAGM)) AARCH64_ARCH("armv8.5-a", generic_armv8_a, V8_5A, 8, (V8_4A, SB, SSBS, PREDRES)) AARCH64_ARCH("armv8.6-a", generic_armv8_a, V8_6A, 8, (V8_5A, I8MM, BF16)) -AARCH64_ARCH("armv8.7-a", generic_armv8_a, V8_7A, 8, (V8_6A, LS64)) +AARCH64_ARCH("armv8.7-a", generic_armv8_a, V8_7A, 8, (V8_6A)) AARCH64_ARCH("armv8.8-a", generic_armv8_a, V8_8A, 8, (V8_7A, MOPS)) AARCH64_ARCH("armv8.9-a", generic_armv8_a, V8_9A, 8, (V8_8A)) AARCH64_ARCH("armv8-r", generic_armv8_a, V8R , 8, (V8_4A)) diff --git a/gcc/testsuite/g++.target/aarch64/acle/ls64.C b/gcc/testsuite/g++.target/aarch64/acle/ls64.C index d9002785b578..dcfe6f1af671 100644 --- a/gcc/testsuite/g++.target/aarch64/acle/ls64.C +++ b/gcc/testsuite/g++.target/aarch64/acle/ls64.C @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-additional-options "-march=armv8.7-a" } */ +/* { dg-additional-options "-march=armv8.7-a+ls64" } */ #include int main() { diff --git a/gcc/testsuite/g++.target/aarch64/acle/ls64_lto.C b/gcc/testsuite/g++.target/aarch64/acle/ls64_lto.C index 274a4771e1c1..0198fe2a1b78 100644 --- a/gcc/testsuite/g++.target/aarch64/acle/ls64_lto.C +++ b/gcc/testsuite/g++.target/aarch64/acle/ls64_lto.C @@ -1,5 +1,5 @@ /* { dg-do link { target aarch64_asm_ls64_ok } } */ -/* { dg-additional-options "-march=armv8.7-a -flto" } */ +/* { dg-additional-options "-march=armv8.7-a+ls64 -flto" } */ #include int main() { diff --git a/gcc/testsuite/gcc.target/aarch64/acle/ls64_lto.c b/gcc/testsuite/gcc.target/aarch64/acle/ls64_lto.c index 8b4f24277717..0e5ae0b052b5 100644 --- a/gcc/testsuite/gcc.target/aarch64/acle/ls64_lto.c +++ b/gcc/testsuite/gcc.target/aarch64/acle/ls64_lto.c @@ -1,5 +1,5 @@ /* { dg-do link { target aarch64_asm_ls64_ok } } */ -/* { dg-additional-options "-march=armv8.7-a -flto" } */ +/* { dg-additional-options "-march=armv8.7-a+ls64 -flto" } */ #include int main(void) { diff --git a/gcc/testsuite/gcc.target/aarch64/acle/pr110100.c b/gcc/testsuite/gcc.target/aarch64/acle/pr110100.c index f56d5e619e8a..62a82b97c56d 100644 --- a/gcc/testsuite/gcc.target/aarch64/acle/pr110100.c +++ b/gcc/testsuite/gcc.target/aarch64/acle/pr110100.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-options "-march=armv8.7-a -O2" } */ +/* { dg-options "-march=armv8.7-a+ls64 -O2" } */ #include void do_st64b(data512_t data) { __arm_st64b((void*)0x10000000, data); diff --git a/gcc/testsuite/gcc.target/aarch64/acle/pr110132.c b/gcc/testsuite/gcc.target/aarch64/acle/pr110132.c index fb88d633dd20..423d91b9a99f 100644 --- a/gcc/testsuite/gcc.target/aarch64/acle/pr110132.c +++ b/gcc/testsuite/gcc.target/aarch64/acle/pr110132.c @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-additional-options "-march=armv8.7-a" } */ +/* { dg-additional-options "-march=armv8.7-a+ls64" } */ /* Check that ls64 builtins can be invoked using a preprocesed testcase without triggering bogus builtin warnings, see PR110132. diff --git a/gcc/testsuite/gcc.target/aarch64/options_set_28.c b/gcc/testsuite/gcc.target/aarch64/options_set_28.c index 9e63768581e9..d5b15f8bc583 100644 --- a/gcc/testsuite/gcc.target/aarch64/options_set_28.c +++ b/gcc/testsuite/gcc.target/aarch64/options_set_28.c @@ -1,9 +1,9 @@ /* { dg-do compile } */ -/* { dg-additional-options "-march=armv9.3-a+nopredres+nols64+nomops" } */ +/* { dg-additional-options "-march=armv9.3-a+nopredres+nomops" } */ int main () { return 0; } -/* { dg-final { scan-assembler-times {\.arch armv9\.3\-a\+crc\+nopredres\+nols64\+nomops\n} 1 } } */ +/* { dg-final { scan-assembler-times {\.arch armv9\.3\-a\+crc\+nopredres\+nomops\n} 1 } } */ diff --git a/gcc/testsuite/gcc.target/aarch64/pragma_cpp_predefs_2.c b/gcc/testsuite/gcc.target/aarch64/pragma_cpp_predefs_2.c index 2d76bfc23dfd..d8fc86d15578 100644 --- a/gcc/testsuite/gcc.target/aarch64/pragma_cpp_predefs_2.c +++ b/gcc/testsuite/gcc.target/aarch64/pragma_cpp_predefs_2.c @@ -242,8 +242,8 @@ #pragma GCC push_options #pragma GCC target ("arch=armv8.7-a") -#ifndef __ARM_FEATURE_LS64 -#error "__ARM_FEATURE_LS64 is not defined but should be!" +#ifdef __ARM_FEATURE_LS64 +#error "__ARM_FEATURE_LS64 is defined but should not be!" #endif #pragma GCC pop_options