From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7905) id D9E3C3858D20; Wed, 21 Feb 2024 12:52:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D9E3C3858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708519927; bh=XXkbX431sdINtsixHOZgVbT+2U+ePPqhTp6AiXapo04=; h=From:To:Subject:Date:From; b=ohoD6wTPDxumjsE1YfQDZ3zDXW6ksrCsgx2rXFOreK2osTcw7CRKiL0N5nBan3xar IxR2cuam3ceJGaYQLy1kfWE0mKkNZPVkyZZNrED/IfCYDfIM71BAXivCh1JWr+ihey hZsGPov6z7Y7YYQASPOfQIbPrzvynsSBJFrWnknQ= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Arthur Cohen To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-9113] gccrs: Add variadic check on function params X-Act-Checkin: gcc X-Git-Author: 0xn4utilus X-Git-Refname: refs/heads/trunk X-Git-Oldrev: cdd76382414191134e0dabcc2c9f66f1df5472e7 X-Git-Newrev: e7c1948fbccfff72fe2c25e962528b398123bfb3 Message-Id: <20240221125207.D9E3C3858D20@sourceware.org> Date: Wed, 21 Feb 2024 12:52:07 +0000 (GMT) List-Id: https://gcc.gnu.org/g:e7c1948fbccfff72fe2c25e962528b398123bfb3 commit r14-9113-ge7c1948fbccfff72fe2c25e962528b398123bfb3 Author: 0xn4utilus Date: Wed Feb 14 22:19:15 2024 +0530 gccrs: Add variadic check on function params gcc/rust/ChangeLog: * checks/errors/rust-ast-validation.cc (ASTValidation::visit): Add variadic check on all parameters. gcc/testsuite/ChangeLog: * rust/compile/issue-2850.rs: New test. Signed-off-by: 0xn4utilus Diff: --- gcc/rust/checks/errors/rust-ast-validation.cc | 12 ++++++++---- gcc/testsuite/rust/compile/issue-2850.rs | 17 +++++++++++++++++ 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/gcc/rust/checks/errors/rust-ast-validation.cc b/gcc/rust/checks/errors/rust-ast-validation.cc index d57b7cb70fee..fcba57d0a920 100644 --- a/gcc/rust/checks/errors/rust-ast-validation.cc +++ b/gcc/rust/checks/errors/rust-ast-validation.cc @@ -132,10 +132,14 @@ ASTValidation::visit (AST::Function &function) rust_error_at (function.get_locus (), "free function without a body"); } - if (function.is_variadic ()) - rust_error_at ( - function.get_function_params ().back ()->get_locus (), - "only foreign or % functions may be C-variadic"); + auto &function_params = function.get_function_params (); + for (auto it = function_params.begin (); it != function_params.end (); it++) + { + if (it->get ()->is_variadic ()) + rust_error_at (it->get ()->get_locus (), + "only foreign or % functions may " + "be C-variadic"); + } AST::ContextualASTVisitor::visit (function); } diff --git a/gcc/testsuite/rust/compile/issue-2850.rs b/gcc/testsuite/rust/compile/issue-2850.rs new file mode 100644 index 000000000000..62cbe0f6524b --- /dev/null +++ b/gcc/testsuite/rust/compile/issue-2850.rs @@ -0,0 +1,17 @@ +fn myfun0(...,_:i32) {} +// { dg-error "only foreign or .unsafe extern \"C\". functions may be C-variadic" "" { target *-*-* } .-1 } + +fn myfun1(a:i32,...,_:i32) {} +// { dg-error "only foreign or .unsafe extern \"C\". functions may be C-variadic" "" { target *-*-* } .-1 } + +struct z { + x: f64, + y: f64, +} + +impl z { + fn new(x: f64, ..., y: f64) -> z { + // { dg-error "only foreign or .unsafe extern \"C\". functions may be C-variadic" "" { target *-*-* } .-1 } + z { x: x, y: y } + } +} \ No newline at end of file