public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Lewis Hyatt <lhyatt@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-8353] testsuite: Remove test that should not have been backported [PR105608]
Date: Thu, 22 Feb 2024 14:45:06 +0000 (GMT)	[thread overview]
Message-ID: <20240222144506.C61F3385802D@sourceware.org> (raw)

https://gcc.gnu.org/g:0e438772e788244236045d75cd2be895e2ab4e08

commit r13-8353-g0e438772e788244236045d75cd2be895e2ab4e08
Author: Lewis Hyatt <lhyatt@gmail.com>
Date:   Thu Feb 22 07:50:10 2024 -0500

    testsuite: Remove test that should not have been backported [PR105608]
    
    This test (backported as part of r13-8257, from r14-8465) was not meant to
    be backported, since it fails on some platforms without other GCC 14 patches
    that will not be backported. Remove it from the 13 branch.
    
    gcc/testsuite/ChangeLog:
    
            PR preprocessor/105608
            * g++.dg/pch/line-map-3.C: Removed.
            * g++.dg/pch/line-map-3.Hs: Removed.

Diff:
---
 gcc/testsuite/g++.dg/pch/line-map-3.C  | 23 -----------------------
 gcc/testsuite/g++.dg/pch/line-map-3.Hs |  1 -
 2 files changed, 24 deletions(-)

diff --git a/gcc/testsuite/g++.dg/pch/line-map-3.C b/gcc/testsuite/g++.dg/pch/line-map-3.C
deleted file mode 100644
index 3390d7adba21..000000000000
--- a/gcc/testsuite/g++.dg/pch/line-map-3.C
+++ /dev/null
@@ -1,23 +0,0 @@
-#define UNUSED_MACRO /* { dg-error "UNUSED_MACRO" "" { xfail *-*-* } } */
-#include "line-map-3.H" /* { dg-bogus "-:UNUSED_MACRO" "" { xfail *-*-* } } */
-
-/* { dg-do compile } */
-/* { dg-additional-options "-Werror=unused-macros" } */
-
-/* PR preprocessor/105608 */
-/* This test case is currently xfailed and requires work in libcpp/pch.cc to
-   resolve.  Currently, the macro location is incorrectly assigned to line 2
-   of the header file when read via PCH, because libcpp doesn't try to
-   assign locations relative to the newly loaded line map after restoring
-   the PCH.  */
-
-/* In PCH mode we also complain incorrectly about the command line macro -Dwith_PCH
-   added by dejagnu; that warning would get suppressed if the macro location were
-   correctly restored by libcpp to reflect that it was a command line macro.  */
-/* { dg-bogus "-:with_PCH" "" { xfail *-*-* } 2 } */
-
-/* The reason we used -Werror was to prevent pch.exp from rerunning without PCH;
-   in that case we would get unnecessary XPASS outputs since the test does work
-   fine without PCH.  Once the bug is fixed, remove the -Werror and switch to
-   dg-warning.  */
-/* { dg-regexp {[^[:space:]]*: some warnings being treated as errors} } */
diff --git a/gcc/testsuite/g++.dg/pch/line-map-3.Hs b/gcc/testsuite/g++.dg/pch/line-map-3.Hs
deleted file mode 100644
index 3b6178bfae0f..000000000000
--- a/gcc/testsuite/g++.dg/pch/line-map-3.Hs
+++ /dev/null
@@ -1 +0,0 @@
-/* This space intentionally left blank.  */

                 reply	other threads:[~2024-02-22 14:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240222144506.C61F3385802D@sourceware.org \
    --to=lhyatt@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).