From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 935353858D3C; Mon, 26 Feb 2024 06:32:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 935353858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1708929150; bh=Le1L0KfcnWfNcL1HBdSX+0bP4N22zDgwaJiRXSgX6j4=; h=From:To:Subject:Date:From; b=AJuwKGnrL2RhcZhFdEGt/AJTtUDXL+Qa1lPTsByp00fQhVuEqUDrqgkRYmqctNYrT 68bofJ8yAb9HBwIKQPuLds8CVHGXGjsV5ak26VOGLGMdHGqAsXbQ3w5fk0pZFos0Su bjGr8MCoPGahnejfokrerhFGx8iXemuYMfzTQcdo= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-9172] i386: Fix up x86_function_profiler -masm=intel support [PR114094] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: 4972f97a265c574d51e20373ddefd66576051e5c X-Git-Newrev: 6987f16742bd4fc6bb8118b9efde52fb9169b327 Message-Id: <20240226063230.935353858D3C@sourceware.org> Date: Mon, 26 Feb 2024 06:32:30 +0000 (GMT) List-Id: https://gcc.gnu.org/g:6987f16742bd4fc6bb8118b9efde52fb9169b327 commit r14-9172-g6987f16742bd4fc6bb8118b9efde52fb9169b327 Author: Jakub Jelinek Date: Mon Feb 26 07:30:05 2024 +0100 i386: Fix up x86_function_profiler -masm=intel support [PR114094] In my r14-8214 changes I apparently forgot one \n at the end of an instruction. The corresponding AT&T line looks like: "1:\tcall\t*%s@GOTPCREL(%%rip)\n" but the Intel variant was "1:\tcall\t[QWORD PTR %s@GOTPCREL[rip]]" Fixed thusly. 2024-02-26 Jakub Jelinek PR target/114094 * config/i386/i386.cc (x86_function_profiler): Add missing new-line to printed instruction. * gcc.target/i386/pr114094.c: New test. Diff: --- gcc/config/i386/i386.cc | 2 +- gcc/testsuite/gcc.target/i386/pr114094.c | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc index 4fdab34c91cd..86381b050948 100644 --- a/gcc/config/i386/i386.cc +++ b/gcc/config/i386/i386.cc @@ -22909,7 +22909,7 @@ x86_function_profiler (FILE *file, int labelno ATTRIBUTE_UNUSED) if (!ix86_direct_extern_access) { if (ASSEMBLER_DIALECT == ASM_INTEL) - fprintf (file, "1:\tcall\t[QWORD PTR %s@GOTPCREL[rip]]", + fprintf (file, "1:\tcall\t[QWORD PTR %s@GOTPCREL[rip]]\n", mcount_name); else fprintf (file, "1:\tcall\t*%s@GOTPCREL(%%rip)\n", diff --git a/gcc/testsuite/gcc.target/i386/pr114094.c b/gcc/testsuite/gcc.target/i386/pr114094.c new file mode 100644 index 000000000000..64fe50925923 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr114094.c @@ -0,0 +1,10 @@ +/* PR target/114094 */ +/* { dg-do assemble { target *-*-linux* } } */ +/* { dg-require-effective-target masm_intel } */ +/* { dg-require-effective-target pie } */ +/* { dg-options "-fpie -fprofile -mno-direct-extern-access -masm=intel" } */ + +void +foo (void) +{ +}