From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1314) id A16C33858C3A; Thu, 29 Feb 2024 07:14:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A16C33858C3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1709190861; bh=X0e+Yuflzt/BLQbSatAZEOpZqS78tUvbvjmPwYzZ5KI=; h=From:To:Subject:Date:From; b=hsKaRd5uBPrFpnNOyHvvnUtuporOLcDlLeQMKEJJeJjY9UHTnXy722KOqwqDng1rD 54KuXWuCyfe4z3rRVvXOMt+jNhH+nDvAt5LKY97i8c4beRR7vU69x259H75xkDYxAR ldusbDscRgg1dXSxvioHOMOD5JEpN7veiuwXRljY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Andrew Pinski To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-9235] aarch64: Fix memtag builtins vs GC [PR108174] X-Act-Checkin: gcc X-Git-Author: Andrew Pinski X-Git-Refname: refs/heads/trunk X-Git-Oldrev: aab1c5dcd23f014f39b127f74aecd04913945a7f X-Git-Newrev: 5ec7740496a6908b32cd058c0520a2bd5a689bb5 Message-Id: <20240229071421.A16C33858C3A@sourceware.org> Date: Thu, 29 Feb 2024 07:14:21 +0000 (GMT) List-Id: https://gcc.gnu.org/g:5ec7740496a6908b32cd058c0520a2bd5a689bb5 commit r14-9235-g5ec7740496a6908b32cd058c0520a2bd5a689bb5 Author: Andrew Pinski Date: Wed Feb 28 22:39:32 2024 -0800 aarch64: Fix memtag builtins vs GC [PR108174] The memtag builtins were being GC'ed away so we end up with a crash sometimes (maybe even wrong code). This fixes that issue by adding GTY on the variable/struct aarch64_memtag_builtin_data. Committed as obvious after a build/test for aarch64-linux-gnu. PR target/108174 gcc/ChangeLog: * config/aarch64/aarch64-builtins.cc (aarch64_memtag_builtin_data): Make static and mark with GTY. gcc/testsuite/ChangeLog: * gcc.target/aarch64/acle/memtag_4.c: New test. Signed-off-by: Andrew Pinski Diff: --- gcc/config/aarch64/aarch64-builtins.cc | 2 +- gcc/testsuite/gcc.target/aarch64/acle/memtag_4.c | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/gcc/config/aarch64/aarch64-builtins.cc b/gcc/config/aarch64/aarch64-builtins.cc index 277904f6d14..75d21de1401 100644 --- a/gcc/config/aarch64/aarch64-builtins.cc +++ b/gcc/config/aarch64/aarch64-builtins.cc @@ -1840,7 +1840,7 @@ aarch64_init_prefetch_builtin (void) } /* Initialize the memory tagging extension (MTE) builtins. */ -struct +static GTY(()) struct GTY(()) { tree ftype; enum insn_code icode; diff --git a/gcc/testsuite/gcc.target/aarch64/acle/memtag_4.c b/gcc/testsuite/gcc.target/aarch64/acle/memtag_4.c new file mode 100644 index 00000000000..1e209ffc25a --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/acle/memtag_4.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* { dg-options "-march=armv9-a+memtag --param ggc-min-expand=0 --param ggc-min-heapsize=0" } */ +/* PR target/108174 */ +/* Check to make sure that the builtin functions are not GC'ed away. */ +#include "arm_acle.h" + +void g(void) +{ + const char *c; + __arm_mte_increment_tag(c , 0 ); +} +void h(void) +{ + const char *c; + __arm_mte_increment_tag( c,0); +}