From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 636683858436; Wed, 6 Mar 2024 14:14:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 636683858436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1709734488; bh=alcn7Os8D/e5GAcH4kJtH9t0CalKp1S+1gOBZZGpjo8=; h=From:To:Subject:Date:From; b=vzOquatQBSn+O8Mu4gjdaD/Sj8y5CujDyUpouuFmuohJzEV/8SUQZnj7glswnc+uR UhCfzCAZIFvfYe99ekGM+mdhKyMxmGhLUUVjApvusmA0gpK/GnkXwUezP70basMuit iEpmCPdK0GM3+B0M+/RNaHySmQQtzC/doiLTmJ7M= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/rguenth/heads/vect-force-slp)] Avoid bogus SLP outer loop vectorization X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/users/rguenth/heads/vect-force-slp X-Git-Oldrev: 89b9eeedc513042cbaa80b81bc9188a08c92a0bf X-Git-Newrev: d1b89155e4bc4f42a06a36b64208216e5d37e779 Message-Id: <20240306141448.636683858436@sourceware.org> Date: Wed, 6 Mar 2024 14:14:47 +0000 (GMT) List-Id: https://gcc.gnu.org/g:d1b89155e4bc4f42a06a36b64208216e5d37e779 commit d1b89155e4bc4f42a06a36b64208216e5d37e779 Author: Richard Biener Date: Wed Mar 6 15:13:05 2024 +0100 Avoid bogus SLP outer loop vectorization This fixes the check for multiple types which go wrong I think because of bogus pointer IV increments when there are multiple copies of vector stmts in the inner loop. * tree-vect-stmts.cc (vectorizable_load): Avoid outer loop SLP vectorization with multi-copy vector stmts in the inner loop. (vectorizable_store): Likewise. Diff: --- gcc/tree-vect-stmts.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 8766ef220c2..2bee550f4a9 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -8176,7 +8176,9 @@ vectorizable_store (vec_info *vinfo, gcc_assert (ncopies >= 1); /* FORNOW. This restriction should be relaxed. */ - if (loop && nested_in_vect_loop_p (loop, stmt_info) && ncopies > 1) + if (loop + && nested_in_vect_loop_p (loop, stmt_info) + && (ncopies > 1 || (slp && SLP_TREE_NUMBER_OF_VEC_STMTS (slp_node) > 1))) { if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location, @@ -9917,7 +9919,8 @@ vectorizable_load (vec_info *vinfo, gcc_assert (ncopies >= 1); /* FORNOW. This restriction should be relaxed. */ - if (nested_in_vect_loop && ncopies > 1) + if (nested_in_vect_loop + && (ncopies > 1 || (slp && SLP_TREE_NUMBER_OF_VEC_STMTS (slp_node) > 1))) { if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,