public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: "François-Xavier Coudert" <fxcoudert@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-9367] testsuite, darwin: improve check for -shared support
Date: Thu,  7 Mar 2024 20:40:31 +0000 (GMT)	[thread overview]
Message-ID: <20240307204031.DDB1C3858002@sourceware.org> (raw)

https://gcc.gnu.org/g:0ed6e5b4820e01fa86b48a7b1d62f752ec97ea41

commit r14-9367-g0ed6e5b4820e01fa86b48a7b1d62f752ec97ea41
Author: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date:   Thu Mar 7 17:27:17 2024 +0100

    testsuite, darwin: improve check for -shared support
    
    The undefined symbols are allowed for C checks, but when
    this is run as C++, the mangled foo() symbol is still
    seen as undefined, and the testsuite thinks darwin does not
    support -shared.
    
    gcc/testsuite/ChangeLog:
    
            PR target/114233
            * lib/target-supports.exp: Fix test for C++.

Diff:
---
 gcc/testsuite/lib/target-supports.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index ae33c4f1e3a..467b539b20d 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -1390,7 +1390,7 @@ proc check_effective_target_shared { } {
     # here to be undefined.
     set extra_flags ""
     if { [istarget *-*-darwin\[912\]*] } {
-      set extra_flags "-Wl,-U,_foo,-U,_bar"
+      set extra_flags "-Wl,-U,_foo,-U,_bar,-U,__Z3foov"
     }
     # Note that M68K has a multilib that supports -fpic but not
     # -fPIC, so we need to check both.  We test with a program that

                 reply	other threads:[~2024-03-07 20:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240307204031.DDB1C3858002@sourceware.org \
    --to=fxcoudert@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).