public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r14-9401] [PR113790][LRA]: Fixing LRA ICE on riscv64
@ 2024-03-08 19:53 Vladimir Makarov
0 siblings, 0 replies; only message in thread
From: Vladimir Makarov @ 2024-03-08 19:53 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:cebbaa2a84586a7345837f74a53b7a0263bf29ee
commit r14-9401-gcebbaa2a84586a7345837f74a53b7a0263bf29ee
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date: Fri Mar 8 14:48:33 2024 -0500
[PR113790][LRA]: Fixing LRA ICE on riscv64
LRA failed to consider all insn alternatives when non-reload pseudo
did not get a hard register. This resulted in failure to generate
code by LRA. The patch fixes this problem.
gcc/ChangeLog:
PR target/113790
* lra-assigns.cc (assign_by_spills): Set up all_spilled_pseudos
for non-reload pseudo too.
Diff:
---
gcc/lra-assigns.cc | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/gcc/lra-assigns.cc b/gcc/lra-assigns.cc
index d1b2b35ffc9..7dfa6f70941 100644
--- a/gcc/lra-assigns.cc
+++ b/gcc/lra-assigns.cc
@@ -1430,13 +1430,19 @@ assign_by_spills (void)
hard_regno = spill_for (regno, &all_spilled_pseudos, iter == 1);
if (hard_regno < 0)
{
- if (reload_p) {
- /* Put unassigned reload pseudo first in the
- array. */
- regno2 = sorted_pseudos[nfails];
- sorted_pseudos[nfails++] = regno;
- sorted_pseudos[i] = regno2;
- }
+ if (reload_p)
+ {
+ /* Put unassigned reload pseudo first in the array. */
+ regno2 = sorted_pseudos[nfails];
+ sorted_pseudos[nfails++] = regno;
+ sorted_pseudos[i] = regno2;
+ }
+ else
+ {
+ /* Consider all alternatives on the next constraint
+ subpass. */
+ bitmap_set_bit (&all_spilled_pseudos, regno);
+ }
}
else
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-08 19:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-08 19:53 [gcc r14-9401] [PR113790][LRA]: Fixing LRA ICE on riscv64 Vladimir Makarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).