From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7824) id BA6AA3858D20; Tue, 9 Apr 2024 18:12:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA6AA3858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1712686375; bh=iOm3Fy37rz+vu5lgYQ7bdVZc1kskXyZDQUu6IDsKNaE=; h=From:To:Subject:Date:From; b=pi4FpBLm42agXngcCg70hygBrRZ6aDENfbVgad+e7RccBe6Ycl72ctJONekwQg1MI aK6BoXINQ2pp6TarfiGyVraSoJPh19JHTj4ZSB0u2Tdby0n4GSFDhuRB5mDLFYItq7 Y2/riB/hMIGtLDoz9aAQ8ocstbEVnqYODpWloI+I= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: David Faust To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-9878] btf: improve btf-datasec-3.c test [PR114642] X-Act-Checkin: gcc X-Git-Author: David Faust X-Git-Refname: refs/heads/master X-Git-Oldrev: 1f719aa7c0d35b47f3d15a54f074718b78e92bb0 X-Git-Newrev: 639215c5eb6c56ba3830cd868d1d3ddd700b4c90 Message-Id: <20240409181255.BA6AA3858D20@sourceware.org> Date: Tue, 9 Apr 2024 18:12:55 +0000 (GMT) List-Id: https://gcc.gnu.org/g:639215c5eb6c56ba3830cd868d1d3ddd700b4c90 commit r14-9878-g639215c5eb6c56ba3830cd868d1d3ddd700b4c90 Author: David Faust Date: Mon Apr 8 13:33:48 2024 -0700 btf: improve btf-datasec-3.c test [PR114642] This test failed on powerpc --target_board=unix'{-m32}' because two variables were not placed in sections where the test silently (and incorrectly) assumed they would be. The important thing for the test is only that BTF_KIND_DATASEC entries are NOT generated for the extern variable declarations without an explicit section attribute. Make the test more robust by placing the non-extern variables in explicit sections, and invert the checks to more accurately verify what we care about in this test. gcc/testsuite/ PR testsuite/114642 * gcc.dg/debug/btf/btf-datasec-3.c: Make test more robust on different architectures. Diff: --- gcc/testsuite/gcc.dg/debug/btf/btf-datasec-3.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-3.c b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-3.c index 297340cabfa..6b127aa14da 100644 --- a/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-3.c +++ b/gcc/testsuite/gcc.dg/debug/btf/btf-datasec-3.c @@ -7,22 +7,22 @@ extern int VERSION __attribute__((section (".version"))); -extern int test_bss1; -extern int test_data1; +extern int ext1; +extern int ext2; -int test_bss2; -int test_data2 = 2; +int var1 __attribute__((section (".sec_a"))); +int var2 __attribute__((section (".sec_b"))) = 2; int foo (void) { - test_bss2 = VERSION; - return test_bss1 + test_data1 + test_data2; + ext2 = VERSION; + return ext1 + var1 + var2; } /* There should be 3 DATASEC entries total. Of the extern decls, only VERSION has a known section; entries are not created for the other two. */ /* { dg-final { scan-assembler-times "bts_type" 3 } } */ -/* { dg-final { scan-assembler-times "bts_type: \\(BTF_KIND_VAR 'test_data2'\\)" 1 } } */ -/* { dg-final { scan-assembler-times "bts_type: \\(BTF_KIND_VAR 'test_bss2'\\)" 1 } } */ /* { dg-final { scan-assembler-times "bts_type: \\(BTF_KIND_VAR 'VERSION'\\)" 1 } } */ +/* { dg-final { scan-assembler-not "bts_type: \\(BTF_KIND_VAR 'ext1'\\)" } } */ +/* { dg-final { scan-assembler-not "bts_type: \\(BTF_KIND_VAR 'ext2'\\)" } } */