public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r14-9885] Revert "combine: Don't combine if I2 does not change"
Date: Wed, 10 Apr 2024 05:59:32 +0000 (GMT)	[thread overview]
Message-ID: <20240410055932.6D1A3385840B@sourceware.org> (raw)

https://gcc.gnu.org/g:109f1b28fc94c93096506e3df0c25e331cef19d0

commit r14-9885-g109f1b28fc94c93096506e3df0c25e331cef19d0
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Apr 10 07:57:03 2024 +0200

    Revert "combine: Don't combine if I2 does not change"
    
    This reverts commit 839bc42772ba7af66af3bd16efed4a69511312ae.

Diff:
---
 gcc/combine.cc | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/gcc/combine.cc b/gcc/combine.cc
index 71c9abc145c..92b8d98e6c1 100644
--- a/gcc/combine.cc
+++ b/gcc/combine.cc
@@ -4196,17 +4196,6 @@ try_combine (rtx_insn *i3, rtx_insn *i2, rtx_insn *i1, rtx_insn *i0,
       adjust_for_new_dest (i3);
     }
 
-  /* If I2 didn't change, this is not a combination (but a simplification or
-     canonicalisation with context), which should not be done here.  Doing
-     it here explodes the algorithm.  Don't.  */
-  if (rtx_equal_p (newi2pat, PATTERN (i2)))
-    {
-      if (dump_file)
-	fprintf (dump_file, "i2 didn't change, not doing this\n");
-      undo_all ();
-      return 0;
-    }
-
   /* We now know that we can do this combination.  Merge the insns and
      update the status of registers and LOG_LINKS.  */

                 reply	other threads:[~2024-04-10  5:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240410055932.6D1A3385840B@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).