public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r14-10088] tree-optimization/114799 - SLP and patterns Date: Tue, 23 Apr 2024 08:23:25 +0000 (GMT) [thread overview] Message-ID: <20240423082326.300183858D38@sourceware.org> (raw) https://gcc.gnu.org/g:18e8e55487238237f37f621668fdee316624981a commit r14-10088-g18e8e55487238237f37f621668fdee316624981a Author: Richard Biener <rguenther@suse.de> Date: Tue Apr 23 08:39:03 2024 +0200 tree-optimization/114799 - SLP and patterns The following plugs a hole with computing whether a SLP node has any pattern stmts which is important to know when we want to replace it by a CTOR from external defs. PR tree-optimization/114799 * tree-vect-slp.cc (vect_get_and_check_slp_defs): Properly update ->any_pattern when swapping operands. * gcc.dg/vect/bb-slp-pr114799.c: New testcase. Diff: --- gcc/testsuite/gcc.dg/vect/bb-slp-pr114799.c | 16 ++++++++++++++++ gcc/tree-vect-slp.cc | 6 ++++++ 2 files changed, 22 insertions(+) diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-pr114799.c b/gcc/testsuite/gcc.dg/vect/bb-slp-pr114799.c new file mode 100644 index 00000000000..70572fe703b --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-pr114799.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* { dg-additional-options "-fno-tree-forwprop" } */ + +unsigned long x; +unsigned char y; + +void +foo (void) +{ + unsigned long tt = y; + tt+=255; + unsigned short t1 = tt; + t1 = 254 - t1; + tt += ((unsigned long)t1); + x = tt; +} diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 30589e19a17..133606fa6f3 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -888,6 +888,12 @@ vect_get_and_check_slp_defs (vec_info *vinfo, unsigned char swap, (*oprnds_info)[i+1]->def_stmts[stmt_num]); std::swap ((*oprnds_info)[i]->ops[stmt_num], (*oprnds_info)[i+1]->ops[stmt_num]); + /* After swapping some operands we lost track whether an + operand has any pattern defs so be conservative here. */ + if ((*oprnds_info)[i]->any_pattern + || (*oprnds_info)[i+1]->any_pattern) + (*oprnds_info)[i]->any_pattern + = (*oprnds_info)[i+1]->any_pattern = true; swapped = true; continue; }
reply other threads:[~2024-04-23 8:23 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240423082326.300183858D38@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).