public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Iain D Sandoe <iains@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-11342] testsuite, Darwin : Do not claim 'GAS' for cctools assembler.
Date: Tue, 23 Apr 2024 14:12:13 +0000 (GMT)	[thread overview]
Message-ID: <20240423141213.23C043858C42@sourceware.org> (raw)

https://gcc.gnu.org/g:5568dda5a01cba6925b3fe5a2ae8a56caee539c5

commit r11-11342-g5568dda5a01cba6925b3fe5a2ae8a56caee539c5
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Mon Mar 15 21:38:31 2021 +0000

    testsuite, Darwin : Do not claim 'GAS' for cctools assembler.
    
    Although the cctools assembler is based of GNU GAS, it is from a
    very old version (1.38) which does not support many of the features
    that the target supports test is expecting.
    
    gcc/testsuite/ChangeLog:
    
            * lib/target-supports.exp: Exclude cctools assembler based on
            GAS 1.38.
    
    (cherry picked from commit e42ea63bcc12e819c3e1066974a691988e86b724)

Diff:
---
 gcc/testsuite/lib/target-supports.exp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 63a5f5579be..876b972a433 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -9576,7 +9576,14 @@ proc check_effective_target_gas { } {
 	set status [remote_exec host "$gcc_as" "-v /dev/null"]
 	set as_output [lindex $status 1]
 	if { [ string first "GNU" $as_output ] >= 0 } {
-	    set use_gas_saved 1
+	    # Some Darwin versions have an assembler which is based on an old
+	    # version of GAS (and reports GNU assembler in its -v output) but
+	    # but doesn't support many of the modern GAS features.
+	    if { [ string first "cctools" $as_output ] >= 0 } {
+	        set use_gas_saved 0
+	    } else {
+	        set use_gas_saved 1
+	    }
 	} else {
 	    set use_gas_saved 0
 	}

                 reply	other threads:[~2024-04-23 14:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240423141213.23C043858C42@sourceware.org \
    --to=iains@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).