public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Iain D Sandoe <iains@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-11360] fixincludes: Update darwin_flt_eval_method for macOS 14
Date: Wed, 24 Apr 2024 18:40:49 +0000 (GMT)	[thread overview]
Message-ID: <20240424184049.35489385840D@sourceware.org> (raw)

https://gcc.gnu.org/g:cb1e6094f3711897615c58ad6b0e53ec69ea9e39

commit r11-11360-gcb1e6094f3711897615c58ad6b0e53ec69ea9e39
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Thu Aug 17 10:16:57 2023 +0200

    fixincludes: Update darwin_flt_eval_method for macOS 14
    
    On macOS 14, a guard in <math.h> changed:
    
    -- MacOSX13.3.sdk/usr/include/math.h    2023-04-19 01:54:44
    +++ MacOSX14.0.sdk/usr/include/math.h   2023-08-01 08:42:43
    @@ -22,0 +23 @@
    +
    @@ -43 +44 @@
    -#if __FLT_EVAL_METHOD__ == 0
    +#if __FLT_EVAL_METHOD__ == 0 || __FLT_EVAL_METHOD__ == -1
    @@ -49 +50 @@
    -#elif __FLT_EVAL_METHOD__ == 2 || __FLT_EVAL_METHOD__ == -1
    +#elif __FLT_EVAL_METHOD__ == 2
    
    Therefore the darwin_flt_eval_method fixincludes fix doesn't match any
    longer, leading to a large number of testsuite failures like
    
    /private/var/gcc/regression/master/14-gcc/build/gcc/include-fixed/math.h:69:5:
    error: #error "Unsupported value of __FLT_EVAL_METHOD__."
    
    where __FLT_EVAL_METHOD__ = 16.
    
    This patch adjusts the fix to allow for both forms.
    
    Tested with make check in fixincludes on x86_64-apple-darwin23.0.0 and
    verifying that <math.h> has indeed been fixed as expected.
    
    2023-08-16  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
    
            fixincludes:
            * inclhack.def (darwin_flt_eval_method): Handle macOS 14 guard
            variant.
            * fixincl.x: Regenerate.
            * tests/base/math.h [DARWIN_FLT_EVAL_METHOD_CHECK]: Update test.
    
    (cherry picked from commit 93f803d53b5ccaabded9d7b4512b54da81c1c616)

Diff:
---
 fixincludes/fixincl.x         | 8 ++++----
 fixincludes/inclhack.def      | 7 ++++---
 fixincludes/tests/base/math.h | 1 +
 3 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/fixincludes/fixincl.x b/fixincludes/fixincl.x
index 442de9226b5..055a9a03f85 100644
--- a/fixincludes/fixincl.x
+++ b/fixincludes/fixincl.x
@@ -2,11 +2,11 @@
  *
  * DO NOT EDIT THIS FILE   (fixincl.x)
  *
- * It has been AutoGen-ed  April 12, 2024 at 12:46:40 PM by AutoGen 5.18.7
+ * It has been AutoGen-ed  April 12, 2024 at 01:20:56 PM by AutoGen 5.18.7
  * From the definitions    inclhack.def
  * and the template file   fixincl
  */
-/* DO NOT SVN-MERGE THIS FILE, EITHER Fri Apr 12 12:46:40 BST 2024
+/* DO NOT SVN-MERGE THIS FILE, EITHER Fri Apr 12 13:20:56 BST 2024
  *
  * You must regenerate it.  Use the ./genfixes script.
  *
@@ -3674,7 +3674,7 @@ tSCC* apzDarwin_Flt_Eval_MethodMachs[] = {
  *  content selection pattern - do fix if pattern found
  */
 tSCC zDarwin_Flt_Eval_MethodSelect0[] =
-       "^#if __FLT_EVAL_METHOD__ == 0$";
+       "^#if __FLT_EVAL_METHOD__ == 0( \\|\\| __FLT_EVAL_METHOD__ == -1)?$";
 
 #define    DARWIN_FLT_EVAL_METHOD_TEST_CT  1
 static tTestDesc aDarwin_Flt_Eval_MethodTests[] = {
@@ -3685,7 +3685,7 @@ static tTestDesc aDarwin_Flt_Eval_MethodTests[] = {
  */
 static const char* apzDarwin_Flt_Eval_MethodPatch[] = {
     "format",
-    "#if __FLT_EVAL_METHOD__ == 0 || __FLT_EVAL_METHOD__ == 16",
+    "%0 || __FLT_EVAL_METHOD__ == 16",
     (char*)NULL };
 
 /* * * * * * * * * * * * * * * * * * * * * * * * * *
diff --git a/fixincludes/inclhack.def b/fixincludes/inclhack.def
index 6478ca19932..0782fb05c85 100644
--- a/fixincludes/inclhack.def
+++ b/fixincludes/inclhack.def
@@ -1819,10 +1819,11 @@ fix = {
     hackname  = darwin_flt_eval_method;
     mach      = "*-*-darwin*";
     files     = math.h;
-    select    = "^#if __FLT_EVAL_METHOD__ == 0$";
+    select    = "^#if __FLT_EVAL_METHOD__ == 0( \\|\\| __FLT_EVAL_METHOD__ == -1)?$";
     c_fix     = format;
-    c_fix_arg = "#if __FLT_EVAL_METHOD__ == 0 || __FLT_EVAL_METHOD__ == 16";
-    test_text = "#if __FLT_EVAL_METHOD__ == 0";
+    c_fix_arg = "%0 || __FLT_EVAL_METHOD__ == 16";
+    test_text = "#if __FLT_EVAL_METHOD__ == 0\n"
+		"#if __FLT_EVAL_METHOD__ == 0 || __FLT_EVAL_METHOD__ == -1";
 };
 
 /*
diff --git a/fixincludes/tests/base/math.h b/fixincludes/tests/base/math.h
index 58f695f9adf..8005e39bc32 100644
--- a/fixincludes/tests/base/math.h
+++ b/fixincludes/tests/base/math.h
@@ -32,6 +32,7 @@
 
 #if defined( DARWIN_FLT_EVAL_METHOD_CHECK )
 #if __FLT_EVAL_METHOD__ == 0 || __FLT_EVAL_METHOD__ == 16
+#if __FLT_EVAL_METHOD__ == 0 || __FLT_EVAL_METHOD__ == -1 || __FLT_EVAL_METHOD__ == 16
 #endif  /* DARWIN_FLT_EVAL_METHOD_CHECK */

                 reply	other threads:[~2024-04-24 18:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424184049.35489385840D@sourceware.org \
    --to=iains@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).