From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2140) id 68E0E3858CD1; Sun, 28 Apr 2024 05:21:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 68E0E3858CD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1714281713; bh=01wXGQpRWn1Ur1Zq+zMY/onZXpRJCqKkJa6kifnpy6c=; h=From:To:Subject:Date:From; b=u4CKvApRWmv2bRA7/lHt33zbmAWu7W3BTSmQqNHtaCFXVGnfjmYEddyJlnFY4nF63 jvJ2oDkY/RI0AQdylhcZ0Fmkyla+RFIElfXTPcOEgU5DOinsa2yOX7B6MXxblQon/n JEpdVYbL+ZDdNwk1lm5p49KOwjLCOmCPRB5aA21A= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Alexandre Oliva To: gcc-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] make -freg-struct-return visibly a negative alias of -fpcc-struct-return X-Act-Checkin: gcc X-Git-Author: Alexandre Oliva X-Git-Refname: refs/users/aoliva/heads/testme X-Git-Oldrev: 7ef60541a89b2e7b3585df434d14010396769ca2 X-Git-Newrev: 4c42beadc660572409d3e6f452bf4c0209f320c3 Message-Id: <20240428052153.68E0E3858CD1@sourceware.org> Date: Sun, 28 Apr 2024 05:21:53 +0000 (GMT) List-Id: https://gcc.gnu.org/g:4c42beadc660572409d3e6f452bf4c0209f320c3 commit 4c42beadc660572409d3e6f452bf4c0209f320c3 Author: Alexandre Oliva Date: Tue Apr 23 00:33:04 2024 -0300 make -freg-struct-return visibly a negative alias of -fpcc-struct-return The fact that both options accept negative forms suggests that maybe they aren't negative forms of each other. They are, but that isn't clear even by examining common.opt. Use NegativeAlias to make it abundantly clear. The 'Optimization' keyword next to freg-struct-return was the only thing that caused flag_pcc_struct_return to be a per-function flag, and ipa-inline relied on that. After making it an alias, the Optimization keyword was no longer operational. I'm not sure it was sensible or desirable for flag_pcc_struct_return to be a per-function setting, but this patch does not intend to change behavior. for gcc/ChangeLog * common.opt (freg-struct-return): Make it explicitly fpcc-struct-return's NegativeAlias. Copy Optimization... (freg-struct-return): ... here. Diff: --- gcc/common.opt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/common.opt b/gcc/common.opt index ad348844775..12d93c76a1e 100644 --- a/gcc/common.opt +++ b/gcc/common.opt @@ -2406,7 +2406,7 @@ Common RejectNegative Joined UInteger Optimization -fpack-struct= Set initial maximum structure member alignment. fpcc-struct-return -Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN) +Common Var(flag_pcc_struct_return,1) Init(DEFAULT_PCC_STRUCT_RETURN) Optimization Return small aggregates in memory, not registers. fpeel-loops @@ -2596,7 +2596,7 @@ Common Var(flag_record_gcc_switches) Record gcc command line switches in the object file. freg-struct-return -Common Var(flag_pcc_struct_return,0) Optimization +Common NegativeAlias Alias(fpcc_struct_return) Optimization Return small aggregates in registers. fregmove