public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r15-20] xfail fetestexcept test - ppc always uses fcmpu
Date: Sun, 28 Apr 2024 07:42:23 +0000 (GMT)	[thread overview]
Message-ID: <20240428074223.73F023858C33@sourceware.org> (raw)

https://gcc.gnu.org/g:6e95dca31c6b4688e0f0a25c9c3aa8a0bedc9056

commit r15-20-g6e95dca31c6b4688e0f0a25c9c3aa8a0bedc9056
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Sun Apr 28 04:30:24 2024 -0300

    xfail fetestexcept test - ppc always uses fcmpu
    
    gcc.dg/torture/pr91323.c tests that a compare with NaNf doesn't set an
    exception using builtin compare intrinsics, and that it does when
    using regular compare operators.
    
    That doesn't seem to be expected to work on powerpc targets.  It fails
    on GNU/Linux, it's marked to be skipped on AIX, and a similar test,
    gcc.dg/torture/pr93133.c, has the execution test xfailed for all of
    powerpc*-*-*.
    
    In this test, the functions that use intrinsics for the compare end up
    with the same code as the one that uses compare operators, using
    fcmpu, a floating compare that, unlike fcmpo, does not set the invalid
    operand exception for quiet NaN.  I couldn't find any evidence that
    the rs6000 backend ever outputs fcmpo.  Therefore, I'm adding the same
    execution xfail marker to this test.
    
    
    for  gcc/testsuite/ChangeLog
    
            PR target/58684
            * gcc.dg/torture/pr91323.c: Expect execution fail on
            powerpc*-*-*.

Diff:
---
 gcc/testsuite/gcc.dg/torture/pr91323.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/torture/pr91323.c b/gcc/testsuite/gcc.dg/torture/pr91323.c
index 1411fcaa396..4574342e728 100644
--- a/gcc/testsuite/gcc.dg/torture/pr91323.c
+++ b/gcc/testsuite/gcc.dg/torture/pr91323.c
@@ -1,4 +1,5 @@
-/* { dg-do run } */
+/* { dg-do run { xfail powerpc*-*-* } } */
+/* remove the xfail for powerpc when pr58684 is fixed */
 /* { dg-add-options ieee } */
 /* { dg-require-effective-target fenv_exceptions } */
 /* { dg-skip-if "fenv" { powerpc-ibm-aix* } } */

                 reply	other threads:[~2024-04-28  7:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240428074223.73F023858C33@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).