From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id BB31D3858D37; Sun, 28 Apr 2024 19:04:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB31D3858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1714331060; bh=naLn98nnXEsDp6aqF7/cucSySD+MkwUthdqEqTSpQns=; h=From:To:Subject:Date:From; b=Wxx6dIcjdKJNn2EagpisSTXMVz83MlXa4bHyskKpClMSuXVoStUQ4EKbzr6UIewgy WtoKzjyWM0uj5bkRHk4wsjPYlDITDDys5Sl2mT0hrsM7HlcWYOii9I1Ac+52reMUYD mybxqwKTso720HH7QeSFb1+rr+Hik9f5GdOz4Wh0= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org Subject: [gcc r15-34] Verify that reading back from vrange_storage doesn't drop bits. X-Act-Checkin: gcc X-Git-Author: Aldy Hernandez X-Git-Refname: refs/heads/master X-Git-Oldrev: d883fc7d00ed6bf5ee151de4fd3e05431582bd5f X-Git-Newrev: 92f74ee21218cab08d7bb7769004a65e8a291fa3 Message-Id: <20240428190420.BB31D3858D37@sourceware.org> Date: Sun, 28 Apr 2024 19:04:20 +0000 (GMT) List-Id: https://gcc.gnu.org/g:92f74ee21218cab08d7bb7769004a65e8a291fa3 commit r15-34-g92f74ee21218cab08d7bb7769004a65e8a291fa3 Author: Aldy Hernandez Date: Tue Mar 19 16:35:41 2024 +0100 Verify that reading back from vrange_storage doesn't drop bits. We have a sanity check in the irange storage code to make sure that reading back a cache entry we have just written to yields exactly the same range. There's no need to do this only for integers. This patch moves the code to a more generic place. However, doing so tickles a latent bug in the frange code where a range is being pessimized from [0.0, 1.0] to [-0.0, 1.0]. Exclude checking frange's until this bug is fixed. gcc/ChangeLog: * value-range-storage.cc (irange_storage::set_irange): Move verification code from here... (vrange_storage::set_vrange): ...to here. Diff: --- gcc/value-range-storage.cc | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/gcc/value-range-storage.cc b/gcc/value-range-storage.cc index f00474ad0e6..09a29776a0e 100644 --- a/gcc/value-range-storage.cc +++ b/gcc/value-range-storage.cc @@ -165,6 +165,19 @@ vrange_storage::set_vrange (const vrange &r) } else gcc_unreachable (); + + // Verify that reading back from the cache didn't drop bits. + if (flag_checking + // FIXME: Avoid checking frange, as it currently pessimizes some ranges: + // + // gfortran.dg/pr49472.f90 pessimizes [0.0, 1.0] into [-0.0, 1.0]. + && !is_a (r) + && !r.undefined_p ()) + { + Value_Range tmp (r); + get_vrange (tmp, r.type ()); + gcc_checking_assert (tmp == r); + } } // Restore R from storage. @@ -306,13 +319,6 @@ irange_storage::set_irange (const irange &r) irange_bitmask bm = r.m_bitmask; write_wide_int (val, len, bm.value ()); write_wide_int (val, len, bm.mask ()); - - if (flag_checking) - { - int_range_max tmp; - get_irange (tmp, r.type ()); - gcc_checking_assert (tmp == r); - } } static inline void