public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r11-11399] testsuite, Darwin: Allow for undefined symbols in shared test.
@ 2024-04-29 14:18 Iain D Sandoe
0 siblings, 0 replies; only message in thread
From: Iain D Sandoe @ 2024-04-29 14:18 UTC (permalink / raw)
To: gcc-cvs
https://gcc.gnu.org/g:8f29a712c404ab272050335c74b2d551c3bd23d3
commit r11-11399-g8f29a712c404ab272050335c74b2d551c3bd23d3
Author: Iain Sandoe <iain@sandoe.co.uk>
Date: Mon Jan 29 10:09:25 2024 +0000
testsuite, Darwin: Allow for undefined symbols in shared test.
Darwin's linker defaults to error on undefined (which makes it look as
if we do not support shared, leading to tests being marked incorrectly
as unsupported).
This fixes the issue by allowing the symbols used in the target
supports test to be undefined.
includes 0ed6e5b4820e01fa86b48a7b1d62f752ec97ea41.
gcc/testsuite/ChangeLog:
* lib/target-supports.exp (check_effective_target_shared):
Allow the external symbols referenced in the test to be undefined.
(cherry picked from commit 639bd5e9b759a6d733fadbd5f956889d965e9368)
Co-authored-by: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Diff:
---
gcc/testsuite/lib/target-supports.exp | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 876b972a433..a059a800298 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -1265,13 +1265,20 @@ proc check_effective_target_aarch64_tlsle32 { } {
# emitted, 0 otherwise.
proc check_effective_target_shared { } {
+ # Darwin's linker defaults to error on undefined (which makes it look as
+ # if we do not support shared) but we can tell it to allow the symbols used
+ # here to be undefined.
+ set extra_flags ""
+ if { [istarget *-*-darwin\[912\]*] } {
+ set extra_flags "-Wl,-U,_foo,-U,_bar,-U,__Z3foov"
+ }
# Note that M68K has a multilib that supports -fpic but not
# -fPIC, so we need to check both. We test with a program that
# requires GOT references.
return [check_no_compiler_messages shared executable {
extern int foo (void); extern int bar;
int baz (void) { return foo () + bar; }
- } "-shared -fpic"]
+ } "-shared -fpic $extra_flags"]
}
# Return 1 if -pie, -fpie and -fPIE are supported, 0 otherwise.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-29 14:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-29 14:18 [gcc r11-11399] testsuite, Darwin: Allow for undefined symbols in shared test Iain D Sandoe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).