public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r15-63] libgcc: Do use weakrefs for glibc 2.34 on GNU Hurd
@ 2024-04-30  7:00 Jakub Jelinek
  0 siblings, 0 replies; only message in thread
From: Jakub Jelinek @ 2024-04-30  7:00 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:3146a92a77f1fccec71a880c7f890a1251aeab41

commit r15-63-g3146a92a77f1fccec71a880c7f890a1251aeab41
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Apr 30 09:00:07 2024 +0200

    libgcc: Do use weakrefs for glibc 2.34 on GNU Hurd
    
    On Mon, Apr 29, 2024 at 01:44:24PM +0000, Joseph Myers wrote:
    > > glibc 2.34 and later doesn't have separate libpthread (libpthread.so.0 is a
    > > dummy shared library with just some symbol versions for compatibility, but
    > > all the pthread_* APIs are in libc.so.6).
    >
    > I suspect this has caused link failures in the glibc testsuite for Hurd,
    > which still has separate libpthread.
    >
    > https://sourceware.org/pipermail/libc-testresults/2024q2/012556.html
    
    So like this then?
    
    2024-04-30  Jakub Jelinek  <jakub@redhat.com>
    
            * gthr.h (GTHREAD_USE_WEAK): Don't redefine to 0 for glibc 2.34+
            on GNU Hurd.

Diff:
---
 libgcc/gthr.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libgcc/gthr.h b/libgcc/gthr.h
index 53a5f0f7458..33c2d8ff630 100644
--- a/libgcc/gthr.h
+++ b/libgcc/gthr.h
@@ -142,7 +142,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively.  If not, see
 #endif
 
 #ifdef __GLIBC_PREREQ
-#if __GLIBC_PREREQ(2, 34)
+#if __GLIBC_PREREQ(2, 34) && !defined(__gnu_hurd__)
 /* glibc 2.34 and later has all pthread_* APIs inside of libc,
    no need to link separately with -lpthread.  */
 #undef GTHREAD_USE_WEAK

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-30  7:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-30  7:00 [gcc r15-63] libgcc: Do use weakrefs for glibc 2.34 on GNU Hurd Jakub Jelinek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).