public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r15-73] Remove support for nontemporal stores with ssa_names on lhs [PR112976]
@ 2024-04-30 15:56 Andrew Pinski
  0 siblings, 0 replies; only message in thread
From: Andrew Pinski @ 2024-04-30 15:56 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:8614d60233a64afd7e28ae7af2ab74c4a5b06010

commit r15-73-g8614d60233a64afd7e28ae7af2ab74c4a5b06010
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Wed Apr 17 14:30:06 2024 -0700

    Remove support for nontemporal stores with ssa_names on lhs [PR112976]
    
    When cfgexpand was changed to support expanding from tuple gimple
    (r0-95521-g28ed065ef9f345), the code was added to support
    doing nontemporal stores with LHS of a SSA_NAME but that will
    never be a nontemporal store.
    This patch removes that and asserts that expanding with a LHS
    of a SSA_NAME is not a nontemporal store.
    
    Bootstrapped and tested on x86_64-linux-gnu.
    
    gcc/ChangeLog:
    
            PR middle-end/112976
            * cfgexpand.cc (expand_gimple_stmt_1): Remove
            support for expanding nontemporal "moves" with
            ssa names on the LHS.
    
    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

Diff:
---
 gcc/cfgexpand.cc | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/gcc/cfgexpand.cc b/gcc/cfgexpand.cc
index eef565eddb5..cfc5291aa0c 100644
--- a/gcc/cfgexpand.cc
+++ b/gcc/cfgexpand.cc
@@ -4002,17 +4002,16 @@ expand_gimple_stmt_1 (gimple *stmt)
 	else
 	  {
 	    rtx target, temp;
-	    bool nontemporal = gimple_assign_nontemporal_move_p (assign_stmt);
+	    gcc_assert (!gimple_assign_nontemporal_move_p (assign_stmt));
 	    bool promoted = false;
 
 	    target = expand_expr (lhs, NULL_RTX, VOIDmode, EXPAND_WRITE);
 	    if (GET_CODE (target) == SUBREG && SUBREG_PROMOTED_VAR_P (target))
 	      promoted = true;
 
-	   /* If we want to use a nontemporal store, force the value to
-	      register first.  If we store into a promoted register,
-	      don't directly expand to target.  */
-	    temp = nontemporal || promoted ? NULL_RTX : target;
+	   /* If we store into a promoted register, don't directly
+	      expand to target.  */
+	    temp = promoted ? NULL_RTX : target;
 	    temp = expand_expr_real_gassign (assign_stmt, temp,
 					     GET_MODE (target), EXPAND_NORMAL);
 
@@ -4034,8 +4033,6 @@ expand_gimple_stmt_1 (gimple *stmt)
 
 		convert_move (SUBREG_REG (target), temp, unsignedp);
 	      }
-	    else if (nontemporal && emit_storent_insn (target, temp))
-	      ;
 	    else
 	      {
 		temp = force_operand (temp, target);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-04-30 15:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-30 15:56 [gcc r15-73] Remove support for nontemporal stores with ssa_names on lhs [PR112976] Andrew Pinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).