public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-8680] tree-optimization/114733 - neg induction fails for 1 element vectors
Date: Fri,  3 May 2024 13:55:09 +0000 (GMT)	[thread overview]
Message-ID: <20240503135509.B7FD13846062@sourceware.org> (raw)

https://gcc.gnu.org/g:b3f9f10e03c570074a517dcfe9df8d3eeddd6aca

commit r13-8680-gb3f9f10e03c570074a517dcfe9df8d3eeddd6aca
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Apr 16 10:46:03 2024 +0200

    tree-optimization/114733 - neg induction fails for 1 element vectors
    
    The neg induction vectorization code isn't prepared to deal with
    single element vectors.
    
            PR tree-optimization/114733
            * tree-vect-loop.cc (vectorizable_nonlinear_induction): Reject
            neg induction vectorization of single element vectors.
    
            * gcc.dg/vect/pr114733.c: New testcase.
    
    (cherry picked from commit 45a41ace55d0ffb1097e374868242329788ec82a)

Diff:
---
 gcc/testsuite/gcc.dg/vect/pr114733.c | 20 ++++++++++++++++++++
 gcc/tree-vect-loop.cc                |  2 ++
 2 files changed, 22 insertions(+)

diff --git a/gcc/testsuite/gcc.dg/vect/pr114733.c b/gcc/testsuite/gcc.dg/vect/pr114733.c
new file mode 100644
index 00000000000..219cbf20469
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/vect/pr114733.c
@@ -0,0 +1,20 @@
+/* { dg-additional-options "-O3" } */
+
+#include "tree-vect.h"
+
+long b = 1;
+signed char c;
+int d[25];
+
+int main()
+{
+  check_vect ();
+  for (signed char g = 0; g < 8; g += 1)
+    for (short h = 0; h < 25; h += 2) {
+      b *= -1;
+      c ^= d[h];
+    }
+  if (b != 1)
+    abort ();
+  return 0;
+}
diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc
index 31ced32126e..73caeb283e3 100644
--- a/gcc/tree-vect-loop.cc
+++ b/gcc/tree-vect-loop.cc
@@ -8944,6 +8944,8 @@ vectorizable_nonlinear_induction (loop_vec_info loop_vinfo,
   switch (induction_type)
     {
     case vect_step_op_neg:
+      if (maybe_eq (TYPE_VECTOR_SUBPARTS (vectype), 1u))
+	return false;
       if (TREE_CODE (init_expr) != INTEGER_CST
 	  && TREE_CODE (init_expr) != REAL_CST)
 	{

                 reply	other threads:[~2024-05-03 13:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240503135509.B7FD13846062@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).