From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1643) id 8FF1538708AC; Tue, 7 May 2024 16:16:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FF1538708AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1715098565; bh=rXCOqMMvSinFNEjSuPCGW9wE6ihcNJzkBxFCvuYXcEU=; h=From:To:Subject:Date:From; b=JIA0pPRK6+EHuivqRO9SvY4+m9bhWok30sl/BZOd/6bB54JEtk8fP9BAcqjt1SBsE GfHkjtfkUf2bX8kpHaM4c2AstD5J/3l4rFQx9jWun29WrD1U57Y4LhOv6b6PuXpFJr /gE/HOKoky1yFx8bktA1qSN2F+tLhSBYxuFeX3Fs= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Thomas Schwinge To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/rust/master] format-args: Add documentation for future expansion of function X-Act-Checkin: gcc X-Git-Author: Arthur Cohen X-Git-Refname: refs/heads/devel/rust/master X-Git-Oldrev: 3ff0f1a7bf230d641503fd1d2a2dc8066a729259 X-Git-Newrev: 61b5a058a49df3c78d2e0f8ac8ef3eca80b67971 Message-Id: <20240507161605.8FF1538708AC@sourceware.org> Date: Tue, 7 May 2024 16:16:05 +0000 (GMT) List-Id: https://gcc.gnu.org/g:61b5a058a49df3c78d2e0f8ac8ef3eca80b67971 commit 61b5a058a49df3c78d2e0f8ac8ef3eca80b67971 Author: Arthur Cohen Date: Fri Mar 1 15:37:45 2024 +0100 format-args: Add documentation for future expansion of function gcc/rust/ChangeLog: * expand/rust-macro-builtins.cc (MacroBuiltin::format_args_handler): Add documentation regarding future tasks. Diff: --- gcc/rust/expand/rust-macro-builtins.cc | 26 +++++--------------------- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/gcc/rust/expand/rust-macro-builtins.cc b/gcc/rust/expand/rust-macro-builtins.cc index b42d1ec9367f..e4ca0d8ba3ba 100644 --- a/gcc/rust/expand/rust-macro-builtins.cc +++ b/gcc/rust/expand/rust-macro-builtins.cc @@ -1052,23 +1052,7 @@ MacroBuiltin::format_args_handler (location_t invoc_locus, { auto input = format_args_parse_arguments (invoc); - // auto fmt_arg - // // FIXME: this eneds to be split up into a smaller function - // = parse_single_string_literal (append_newline ? - // BuiltinMacro::FormatArgsNl - // : BuiltinMacro::FormatArgs, - // invoc.get_delim_tok_tree (), invoc_locus, - // invoc.get_expander ()); - - // if (!fmt_arg->is_literal ()) - // { - // rust_sorry_at ( - // invoc_locus, - // "cannot yet use eager macro invocations as format strings"); - // return AST::Fragment::create_empty (); - // } - - // FIXME: We need to handle this + // TODO(Arthur): We need to handle this // // if it is not a literal, it's an eager macro invocation - return it // if (!fmt_expr->is_literal ()) // { @@ -1077,10 +1061,10 @@ MacroBuiltin::format_args_handler (location_t invoc_locus, // token_tree.to_token_stream ()); // } - // auto fmt_str = static_cast (*fmt_arg.get ()); - - // Switch on the format string to know if the string is raw or cooked - // switch (fmt_str.get_lit_type ()) + // TODO(Arthur): Handle this as well - raw strings are special for the + // format_args parser auto fmt_str = static_cast + // (*fmt_arg.get ()); Switch on the format string to know if the string is raw + // or cooked switch (fmt_str.get_lit_type ()) // { // // case AST::Literal::RAW_STRING: // case AST::Literal::STRING: