From: Jakub Jelinek <jakub@redhat.com>
To: JonY <10walls@gmail.com>
Cc: gcc-help@gcc.gnu.org, Liu Hao <lh_mouse@126.com>
Subject: Re: mingw-w64 and __attribute__((format(printf))) issue
Date: Tue, 12 May 2020 14:02:55 +0200 [thread overview]
Message-ID: <20200512120255.GJ8462@tucnak> (raw)
In-Reply-To: <ea960c6f-81cd-1373-d4cf-25932fc5e48b@gmail.com>
On Tue, May 12, 2020 at 11:14:02AM +0000, JonY wrote:
> >> I think option #3 is the simplest approach in the short term, though I
> >> prefer option #2.
> >>
> >
> > This patch has been accepted by MSYS2 [1], tested for bootstrapping on
> > both i686 and x86_64.
> >
> > So here comes a 4th option: Disable `-Werror` if `--disable-werror` is
> > specified to the top-level configure.
> >
> > EGREP'ing for `(format|__format__)\s*\(\s*(__printf__|printf)` in GCC
> > source reveals ~30 matches (excluding testsuites). Probably they should
> > all be fixed similarly, or we ignore such warnings for simplicity.
> > libgomp doesn't build despite `--disable-werror` at top level, which
> > seems a bug in this case.
> >
> >
> > [1]
> > https://github.com/msys2/MINGW-packages/blob/9501ee2afc8d01dc7d85383e4b22e91c30d93ca7/mingw-w64-gcc/0020-libgomp-Don-t-hard-code-MS-printf-attributes.patch
> >
> >
>
> Any thoughts on the libgomp printf attribute changes?
gomp_fatal etc. call vfprintf under the hood though, does that one handle
%llu on mingw? If not, using %llu for the PRI* macros looks wrong to me.
Jakub
next prev parent reply other threads:[~2020-05-12 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 5:36 Liu Hao
2020-05-06 10:48 ` [Mingw-w64-public] " Martin Storsjö
2020-05-06 12:45 ` Liu Hao
2020-05-07 4:09 ` Liu Hao
2020-05-10 4:27 ` JonY
2020-05-10 9:03 ` Liu Hao
2020-05-12 11:14 ` JonY
2020-05-12 12:02 ` Jakub Jelinek [this message]
2020-05-12 13:15 ` Liu Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512120255.GJ8462@tucnak \
--to=jakub@redhat.com \
--cc=10walls@gmail.com \
--cc=gcc-help@gcc.gnu.org \
--cc=lh_mouse@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).