From: Segher Boessenkool <segher@kernel.crashing.org>
To: mark_at_yahoo via Gcc-help <gcc-help@gcc.gnu.org>
Subject: Re: __attribute__ to selectively disable -Wmaybe-uninitialized
Date: Fri, 23 Oct 2020 15:38:32 -0500 [thread overview]
Message-ID: <20201023203832.GH2672@gate.crashing.org> (raw)
In-Reply-To: <caf2f32f-3caf-fc89-0ca6-4c885a7b8ff1@yahoo.com>
On Fri, Oct 23, 2020 at 01:01:13PM -0700, mark_at_yahoo via Gcc-help wrote:
> 3. I don't want to disable -Wmaybe-uninitialized globally, or for an
> entire function. Warnings are "A Good Thing"(tm).
Yes. And you usually should make trivial changes to your program if the
compiler warns, even if you consider that unnecessary -- just so that
you will not miss other warnings!
> 4. Please, no lectures on why local variables should always be
> initialized at declaration.
No, but you can write your code so that it more obviously does not use
unitialised variables. This is an Even Better Thing(tm). The compiler
will understand it, but much more importantly, human readers will
understand it as well!
-Wmaybe-uninitialized has a LOT of false positives if you use anything
but the strictest, simplest control flow. It's the nature of the beast.
> 5. I now see something similar was requested in 2012 in
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55288 but seems to have
> been dismissed with a variation of #4.
It wasn't dismissed, that PR is still open.
Segher
next prev parent reply other threads:[~2020-10-23 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <caf2f32f-3caf-fc89-0ca6-4c885a7b8ff1.ref@yahoo.com>
2020-10-23 20:01 ` mark_at_yahoo
2020-10-23 20:38 ` Segher Boessenkool [this message]
2020-10-23 21:51 ` mark_at_yahoo
2020-10-24 8:49 ` J Decker
2020-10-24 18:32 ` Segher Boessenkool
2020-10-27 8:01 ` mark_at_yahoo
2020-10-24 17:06 ` Florian Weimer
2020-10-24 18:02 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023203832.GH2672@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-help@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).