Re: one of those annoying little things

["Matthew R. Wilson" <mwilson@mattwilson.org>]

On 08.24.2022 12:51, Dennis Clarke wrote:
>------------------ From the GCC Help Maillist ------------------
>On 8/24/22 04:27, Matthew R. Wilson wrote:
>>On 08.24.2022 13:20, Xi Ruoyao via Gcc-help wrote:
>>>On Wed, 2022-08-24 at 00:21 -0400, Dennis Clarke via Gcc-help wrote:
>Good day and thank you good folks for the thoughtful reply.  Indeed yes
>I forgot the footnote for the patch :
>
>    https://www.mpfr.org/mpfr-current/#download
>
>>The instructions on the MPFR patch download page
>><https://www.mpfr.org/mpfr-current/> for the cumulative patch against
>>the 4.1.0 release explicitly tell you to use the following patch
>>command:
>>
>>patch -N -Z -p1 < path_to_patches_file
>
>Yes, I see that and also the words :
>
>    The -Z option sets the modification time of the patched files
>    from time stamps given in the patch file, thus avoiding the need
>    of some development utilities (such as autoconf); this may generate
>    a "Not setting time" warning for the PATCHES file, but you can
>    safely ignore it.
>
>Really?  Can I safely ignore it?  Because NetBSD has no such option for
>the patch command therein.

The "you can safely ignore it" applies to specifically the warning when
trying to set the time on the PATCHES file, not that you can safely
ignore the entire -Z option (or lack thereof).

>Seems that we can not safely ignore that option. Perhaps the failure
>here is with the "patch" software in NetBSD?  Maybe GNU patch is what
>is needed to get that -Z option?

If the patch utility that comes with NetBSD does not have the -Z option,
then yes, that seems to be a problem for the workflow you're trying to
accomplish (protected source tree but using an 'unclean' source
distribution of MPFR during the build since the effects of the -Z option
aren't being correctly applied).

-Matthew