public inbox for gcc-help@gcc.gnu.org
 help / color / mirror / Atom feed
From: Tom N <nospam@codesniffer.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Iain Sandoe <idsandoe@googlemail.com>, gcc-help <gcc-help@gcc.gnu.org>
Subject: Re: Building on Mac with --enable-tls
Date: Sat, 21 Mar 2020 13:26:32 -0400 (EDT)	[thread overview]
Message-ID: <2041593632.124616.1584811592934@email.ionos.com> (raw)
In-Reply-To: <CAH6eHdS_V01ho3N=gcNAoTukvzzcmEHhpDsmRm_qot+ypmvB7g@mail.gmail.com>

> On March 19, 2020 at 10:07 AM Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> 
> Accidentally creating a temporary unique_lock that immediately goes out of scope? :-)
> http://kayari.org/cxx/antipatterns.html#locking-mutex

Not that bad I think. :)  (The code has been in production on Linux & Windows for years so something like that should've popped up already.)

Actually the bad assumption was that my unit tests were doing sufficient testing of my GetThreadId wrapper.  That wasn't working properly on Mac but not triggering an error either.  The synchronization was not the problem--only the Thread IDs being used as keys into a std::map.

Thanks again!

      reply	other threads:[~2020-03-21 17:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 19:14 Tom N
2020-03-18 23:05 ` Jonathan Wakely
2020-03-18 23:53   ` Iain Sandoe
2020-03-19 13:54     ` Tom N
2020-03-19 14:07       ` Jonathan Wakely
2020-03-21 17:26         ` Tom N [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2041593632.124616.1584811592934@email.ionos.com \
    --to=nospam@codesniffer.com \
    --cc=gcc-help@gcc.gnu.org \
    --cc=idsandoe@googlemail.com \
    --cc=jwakely.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).